Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delegation integration test #2518

Merged
merged 18 commits into from May 25, 2019

Conversation

Projects
None yet
2 participants
@psteckler
Copy link
Contributor

commented May 22, 2019

Integration test for stake delegation, which

  • lets delegator propose some blocks
  • runs delegation
  • lets delegatee propose some blocks

We check that:

  • before delegation, only the delegator proposes
  • after delegation, only the delegatee proposes

Added this test to CI.

Some code items that were named *payment* are renamed to *user_command*, because they actually work with payments and delegations.

Development of this test revealed a bug in Proof_of_stake.compute_delegators, fixed here (bug found by @nholland94).

Update: created consensus config postake_nano with c = 1 to speed up the test.

psteckler added some commits May 22, 2019

@psteckler psteckler changed the title Delegation integration test [WIP] Delegation integration test May 22, 2019

@psteckler psteckler changed the title [WIP] Delegation integration test Delegation integration test May 23, 2019

psteckler added some commits May 23, 2019

@psteckler psteckler requested a review from cmr May 23, 2019

@cmr
Copy link
Contributor

left a comment

looks good other than the one nit

in
let%bind delegate =
with_label __LOC__ (Public_key.decompress_var account.delegate)
in
let%bind () =
with_label __LOC__ (Public_key.assert_equal public_key delegate)
in
let%bind () =

This comment has been minimized.

Copy link
@cmr

cmr May 24, 2019

Contributor

This check is the same as the one right above it.

This comment has been minimized.

Copy link
@psteckler

psteckler May 24, 2019

Author Contributor

Merge error on my part, will fix.

psteckler added some commits May 24, 2019

@cmr

cmr approved these changes May 25, 2019

@psteckler psteckler merged commit d00d7ab into master May 25, 2019

20 of 21 checks passed

ci/circleci: test--test_postake_holy_grail CircleCI is running your tests
Details
Summary The new Mergify configuration is valid
Details
ci/circleci: build-artifacts--testnet_postake Your tests passed on CircleCI!
Details
ci/circleci: build-artifacts--testnet_postake_many_proposers Your tests passed on CircleCI!
Details
ci/circleci: build-artifacts--testnet_postake_snarkless_fake_hash Your tests passed on CircleCI!
Details
ci/circleci: build-wallet Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: test--fake_hash Your tests passed on CircleCI!
Details
ci/circleci: test--test_postake Your tests passed on CircleCI!
Details
ci/circleci: test--test_postake_bootstrap Your tests passed on CircleCI!
Details
ci/circleci: test--test_postake_catchup Your tests passed on CircleCI!
Details
ci/circleci: test--test_postake_delegation Your tests passed on CircleCI!
Details
ci/circleci: test--test_postake_five_even_snarkless Your tests passed on CircleCI!
Details
ci/circleci: test--test_postake_five_even_txns Your tests passed on CircleCI!
Details
ci/circleci: test--test_postake_snarkless Your tests passed on CircleCI!
Details
ci/circleci: test--test_postake_split Your tests passed on CircleCI!
Details
ci/circleci: test--test_postake_split_snarkless Your tests passed on CircleCI!
Details
ci/circleci: test--test_postake_txns Your tests passed on CircleCI!
Details
ci/circleci: test-unit--dev Your tests passed on CircleCI!
Details
ci/circleci: test-unit--test_postake_snarkless Your tests passed on CircleCI!
Details
ci/circleci: tracetool Your tests passed on CircleCI!
Details

@psteckler psteckler deleted the feature/delegation-integration-test branch May 25, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.