Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wallet: connect to daemon by default #2669

Merged
merged 3 commits into from Jun 18, 2019

Conversation

Projects
None yet
4 participants
@Schmavery
Copy link
Contributor

commented Jun 17, 2019

The wallet build and runs with all endpoints pointing to the daemon!

You can still run against the faker by running GRAPHQL_BACKEND=faker yarn dev. As soon as we get the daemon running in the dist properly, I'll remove the faker stuff from the dist.

I could swap the default but this is probably what we want eventually lol

@Schmavery Schmavery requested a review from o1pranay Jun 17, 2019

@bkase

bkase approved these changes Jun 17, 2019

~resolve:
(fun {ctx= coda; _} () (from, to_, _amount, fee, maybe_memo) ->
let send_delegation =
io_field "sendDelegation" ~doc:"Send a payment"

This comment has been minimized.

Copy link
@o1pranay

o1pranay Jun 17, 2019

Contributor

nit: change the doc here

@@ -102,6 +97,18 @@ type extractedResponse = {
pending: array(TransactionCell.Transaction.t),
};

let gqlUserCommandToRecord = (userCommand, maybeDate) =>
TransactionCell.Transaction.UserCommand({
TransactionCell.Transaction.PaymentDetails.isDelegation:

This comment has been minimized.

Copy link
@o1pranay

o1pranay Jun 17, 2019

Contributor

why is this key TransactionCell.Transaction.PaymentDetails.isDelegation: instead of isDelegation?

This comment has been minimized.

Copy link
@Schmavery

Schmavery Jun 17, 2019

Author Contributor

the isDelegation is defined inside of TransactionCell.Transaction.PaymentDetails. We could probably do this cleaner by locally opening TransactionCell.Transaction

This comment has been minimized.

Copy link
@o1pranay

o1pranay Jun 17, 2019

Contributor

why do we do it for just the first key, and not the others?


let uri = "http://localhost:49370/graphql";

This comment has been minimized.

Copy link
@o1pranay

o1pranay Jun 17, 2019

Contributor

later maybe we can put 0xc0da in an env var so we can change it

attempts: {
max: 60,
}}
|}

This comment has been minimized.

Copy link
@o1pranay

o1pranay Jun 17, 2019

Contributor

nit spacing

@Schmavery Schmavery force-pushed the wallet-graphql-everything branch from 169158b to c945897 Jun 17, 2019

@o1pranay
Copy link
Contributor

left a comment

thanks for addressing spacing issues and nits

@mergify mergify bot merged commit 6ef0827 into master Jun 18, 2019

21 of 22 checks passed

ci/circleci: test--test_postake_holy_grail CircleCI is running your tests
Details
Rule: automatically merge approved PRs with the ready-to-merge label (merge) The pull request has been merged automatically
Details
Summary 1 rule matches
Details
ci/circleci: build-artifacts--testnet_postake Your tests passed on CircleCI!
Details
ci/circleci: build-artifacts--testnet_postake_many_proposers Your tests passed on CircleCI!
Details
ci/circleci: build-artifacts--testnet_postake_snarkless_fake_hash Your tests passed on CircleCI!
Details
ci/circleci: build-wallet Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: test--fake_hash Your tests passed on CircleCI!
Details
ci/circleci: test--test_postake Your tests passed on CircleCI!
Details
ci/circleci: test--test_postake_bootstrap Your tests passed on CircleCI!
Details
ci/circleci: test--test_postake_catchup Your tests passed on CircleCI!
Details
ci/circleci: test--test_postake_delegation Your tests passed on CircleCI!
Details
ci/circleci: test--test_postake_five_even_snarkless Your tests passed on CircleCI!
Details
ci/circleci: test--test_postake_five_even_txns Your tests passed on CircleCI!
Details
ci/circleci: test--test_postake_snarkless Your tests passed on CircleCI!
Details
ci/circleci: test--test_postake_split Your tests passed on CircleCI!
Details
ci/circleci: test--test_postake_split_snarkless Your tests passed on CircleCI!
Details
ci/circleci: test--test_postake_txns Your tests passed on CircleCI!
Details
ci/circleci: test-unit--dev Your tests passed on CircleCI!
Details
ci/circleci: test-unit--test_postake_snarkless Your tests passed on CircleCI!
Details
ci/circleci: tracetool Your tests passed on CircleCI!
Details

@mergify mergify bot deleted the wallet-graphql-everything branch Jun 18, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.