Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI] re-added macos build job, releases to artifactory every build #2697

Merged
merged 5 commits into from Jun 24, 2019

Conversation

Projects
None yet
2 participants
@yourbuddyconner
Copy link
Contributor

commented Jun 21, 2019

Update to CI

@yourbuddyconner yourbuddyconner requested review from bkase, o1pranay and Schmavery Jun 21, 2019

@yourbuddyconner yourbuddyconner marked this pull request as ready for review Jun 21, 2019

@yourbuddyconner yourbuddyconner requested a review from jkrauska as a code owner Jun 21, 2019

@yourbuddyconner yourbuddyconner force-pushed the feature/macos-portable-ci branch from dd89e9f to db7798f Jun 21, 2019

@bkase
Copy link
Contributor

left a comment

CircleCI configs are annoying -- you also need to add the job to the bottom in the workflows section in order for it to run.

            - build-macos	

@yourbuddyconner yourbuddyconner force-pushed the feature/macos-portable-ci branch from db7798f to e43fa91 Jun 21, 2019

@yourbuddyconner yourbuddyconner requested a review from bkase Jun 21, 2019

@yourbuddyconner yourbuddyconner requested review from cmr and nholland94 as code owners Jun 21, 2019

@yourbuddyconner yourbuddyconner force-pushed the feature/macos-portable-ci branch from 95de912 to 57fb78f Jun 21, 2019

yourbuddyconner added some commits Jun 21, 2019

@bkase

bkase approved these changes Jun 24, 2019

# command: echo "FIXME Tests not yet working on mac"
build-macos:
macos:
xcode: "10.1.0"

This comment has been minimized.

Copy link
@bkase

bkase Jun 24, 2019

Contributor

I'm not sure if this is the right version we should be building for, but I guess we should do it for now.

@bkase

This comment has been minimized.

Copy link
Contributor

commented Jun 24, 2019

This takes a pretty long time, but since we have even slower tests now, it seems safe to turn back on!

@yourbuddyconner yourbuddyconner merged commit 0a6f5fb into master Jun 24, 2019

22 checks passed

Summary 1 potential rule
Details
ci/circleci: build-artifacts--testnet_postake Your tests passed on CircleCI!
Details
ci/circleci: build-artifacts--testnet_postake_many_proposers Your tests passed on CircleCI!
Details
ci/circleci: build-artifacts--testnet_postake_snarkless_fake_hash Your tests passed on CircleCI!
Details
ci/circleci: build-macos Your tests passed on CircleCI!
Details
ci/circleci: build-wallet Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: test--fake_hash Your tests passed on CircleCI!
Details
ci/circleci: test--test_postake Your tests passed on CircleCI!
Details
ci/circleci: test--test_postake_bootstrap Your tests passed on CircleCI!
Details
ci/circleci: test--test_postake_catchup Your tests passed on CircleCI!
Details
ci/circleci: test--test_postake_delegation Your tests passed on CircleCI!
Details
ci/circleci: test--test_postake_five_even_snarkless Your tests passed on CircleCI!
Details
ci/circleci: test--test_postake_five_even_txns Your tests passed on CircleCI!
Details
ci/circleci: test--test_postake_holy_grail Your tests passed on CircleCI!
Details
ci/circleci: test--test_postake_snarkless Your tests passed on CircleCI!
Details
ci/circleci: test--test_postake_split Your tests passed on CircleCI!
Details
ci/circleci: test--test_postake_split_snarkless Your tests passed on CircleCI!
Details
ci/circleci: test--test_postake_txns Your tests passed on CircleCI!
Details
ci/circleci: test-unit--dev Your tests passed on CircleCI!
Details
ci/circleci: test-unit--test_postake_snarkless Your tests passed on CircleCI!
Details
ci/circleci: tracetool Your tests passed on CircleCI!
Details

@yourbuddyconner yourbuddyconner deleted the feature/macos-portable-ci branch Jul 3, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.