Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

testnet no-snark-work fix #3195

Merged
merged 5 commits into from Aug 14, 2019
Merged

testnet no-snark-work fix #3195

merged 5 commits into from Aug 14, 2019

Conversation

deepthiskumar
Copy link
Member

No snark work was being done until the first tree was filled. All the work returned by Parallel_scan.all_jobs is in a specific order and some trees weren't being included during the ordering process due to an off-by-one error.

Checklist:

  • Tests were added for the new behavior
  • All tests pass (CI will check this if you didn't)
  • Serialized types are in stable-versioned modules
  • Does this close issues? List them:

Copy link
Member

@bkase bkase left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! Was going to ask for the test, but you’re way ahead of me.

@deepthiskumar deepthiskumar added the ready-to-merge Adding this label will trigger mergify and trigger CI to run and merge the PR label Aug 14, 2019
@mergify mergify bot merged commit 983f5de into develop Aug 14, 2019
@mergify mergify bot deleted the fix/ps-delay branch August 14, 2019 22:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-merge Adding this label will trigger mergify and trigger CI to run and merge the PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants