Improve Logproc documentation #3220
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emberian
approved these changes
Aug 16, 2019
src/app/logproc/logproc.ml
Outdated
| [ `S Manpage.s_description | ||
| ; `P | ||
| "Logproc processes coda logs from stdin and is capable of filtering \ | ||
| and reformating logs in a user friendly fashion. A simple \ |
There was a problem hiding this comment.
IMO nix both uses of simple. Otherwise, just one is probably enough!
|
Simple too simple for you? :) |
emberian
approved these changes
Aug 16, 2019
nholland94
added
the
ready-to-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Wanted to get this in real quick before I leave. Feedback on logproc has been that it's not easy to use, so I wrote some better manpage docs complete with examples. I also cleaned up the annoying output it generates on failure to parse json.