Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't die if the target peer is banned in try_call_rpc #3881

Merged
merged 2 commits into from Nov 11, 2019

Conversation

@enolan
Copy link
Contributor

enolan commented Nov 8, 2019

This was causing crashes on the release candidate testnet. Since it's a race I don't have a good way to test if the fix works locally, but it's logically sound and we'll see when the next internal testnet goes up.

@enolan enolan requested review from bkase and cmr as code owners Nov 8, 2019
@cmr
cmr approved these changes Nov 8, 2019
@mergify mergify bot merged commit 5c945c0 into develop Nov 11, 2019
21 of 24 checks passed
21 of 24 checks passed
ci/circleci: build-archive Your tests failed on CircleCI
Details
ci/circleci: test--test_postake_holy_grail Your tests failed on CircleCI
Details
ci/circleci: build-macos CircleCI is running your tests
Details
Summary 1 rule matches
Details
ci/circleci: build-artifacts--testnet_postake_medium_curves Your tests passed on CircleCI!
Details
ci/circleci: build-auxiliary Your tests passed on CircleCI!
Details
ci/circleci: build-wallet Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: lint-opt Your tests passed on CircleCI!
Details
ci/circleci: test--fake_hash Your tests passed on CircleCI!
Details
ci/circleci: test--test_postake Your tests passed on CircleCI!
Details
ci/circleci: test--test_postake_bootstrap Your tests passed on CircleCI!
Details
ci/circleci: test--test_postake_catchup Your tests passed on CircleCI!
Details
ci/circleci: test--test_postake_delegation Your tests passed on CircleCI!
Details
ci/circleci: test--test_postake_five_even_snarkless Your tests passed on CircleCI!
Details
ci/circleci: test--test_postake_five_even_txns Your tests passed on CircleCI!
Details
ci/circleci: test--test_postake_snarkless Your tests passed on CircleCI!
Details
ci/circleci: test--test_postake_split Your tests passed on CircleCI!
Details
ci/circleci: test--test_postake_split_snarkless Your tests passed on CircleCI!
Details
ci/circleci: test--test_postake_three_proposers Your tests passed on CircleCI!
Details
ci/circleci: test--test_postake_txns Your tests passed on CircleCI!
Details
ci/circleci: test-unit--dev Your tests passed on CircleCI!
Details
ci/circleci: test-unit--test_postake_snarkless_unittest Your tests passed on CircleCI!
Details
ci/circleci: tracetool Your tests passed on CircleCI!
Details
@mergify mergify bot deleted the fix/banned_peer_try_call_rpc branch Nov 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.