adding notstarted to generic async actions and reducer #39
Conversation
jackblanc
left a comment
jackblanc
left a comment
There was a problem hiding this comment.
This looks good, but considering this is a core util, I think we need a unit test. There's a few things that shouldn't be too complicated to test here. First, we want to expect that genericAsyncActions now additionally returns the notStarted actions for all AsyncRequests. Second, we want to expect that calling the reducer with this generated action will result in the field being returned as an AsyncRequestNotStarted. Let me know if you want help with this. Hey, maybe coveralls will go up for once!
|
Imagine writing tests 😅 |
| const action = authenticateUser.notStarted(); | ||
| const authenticatedState: UserAuthenticationReducerState = { | ||
| ...initialUserState, | ||
| tokens: AsyncRequestCompleted<TokenPayload, void>(payload), |
There was a problem hiding this comment.
I think technically it's an any error right?
jackblanc
left a comment
jackblanc
left a comment
There was a problem hiding this comment.
🚢, not sure if change void to any matters at all
|
It passes so hey lgtm |
Why
When logging out and deleting the user we need to clear tokens in redux, we currently dont have the ability to do this with an action, so this PR aims to add that feature.