create login signup pages #3
Conversation
florisdobber
left a comment
florisdobber
left a comment
There was a problem hiding this comment.
Looks great overall! Just the minor comment
src/containers/signup/Signup.tsx
Outdated
| name="cemail" | ||
| rules={[{ required: true, message: 'Please confirm your email!' }]} | ||
| > | ||
| <Input placeholder="Confirm Email"/> |
There was a problem hiding this comment.
We don't confirm email addresses. That's a mistake in the design sorry, but can you take it out and just make it a long input field like the password ones below?
|
You should be able to fix the CI build with |
|
I resolved the merge conflicts from the changes to frontend-scaffold |
| @@ -1,0 +1,78 @@ | |||
| .body-content-container { | |||
There was a problem hiding this comment.
💭 Could we share some of these styles between the two containers? It looks like a lot of them are the same between the two pages.
|
@SofieDunt I made a bunch of changes to frontend scaffold and wanted to make sure they work properly across downstream repos, so that's the reason for the commits above. |
Why
Monday.com Ticket
This PR
Created login and signup pages (and corresponding containers)
Screenshots
Left: Design, Right: Finished Page (excluding NavBar)
Verification Steps