Feature #350: URL pasting into document #359

Merged
merged 2 commits into from Mar 23, 2013

Conversation

Projects
None yet
2 participants
Contributor

Shazbot commented Mar 16, 2013

No description provided.

@@ -336,7 +336,7 @@
</i:Interaction.Triggers>
</Button>
<Button x:Name="PrintDocument" Content="print" Style="{StaticResource OpenDocumentsOnly}" />
- <Button x:Name="PublishDocument" Content="publish" Style="{StaticResource OpenDocumentsOnly}" />
+ <Button x:Name="PublishDocument" Content="publish" Style="{StaticResource OpenDocumentsOnly}" Command="{Binding PublishDocumentCommand}" />
@JakeGinnivan

JakeGinnivan Mar 18, 2013

Member

This should be taken care of by caliburn micro i think?

@Shazbot

Shazbot Mar 18, 2013

Contributor

Clicking Publish doesn't do anything for me. PublishDocument in the viewModel is private, and caliburn doesn't wire up commands. Think this was an oversight.

@@ -12,6 +12,10 @@ public MarkpadFixture()
var directoryName = Path.GetDirectoryName(Assembly.GetExecutingAssembly().Location);
var environmentLocation = Environment.GetEnvironmentVariable("MarkpadLocation");
var markpadLocation = environmentLocation ?? Path.Combine(directoryName, @"..\..\..\Markpad\bin\Debug\Markpad.exe");
+ if (!File.Exists(markpadLocation))
@Shazbot

Shazbot Mar 18, 2013

Contributor

For me, when running tests environmentLocation is null and I don't get a Markpad folder in the temp directory, just folders with xunit.DLL, TestStack.White.DLL, and the Markpad.UITests.DLL one.

@JakeGinnivan

JakeGinnivan Mar 23, 2013

Member

Not sure this is required, but it can't hurt so I will look into it later

JakeGinnivan added a commit that referenced this pull request Mar 23, 2013

Merge pull request #359 from Shazbot/pasteURL
Feature #350: URL pasting into document

@JakeGinnivan JakeGinnivan merged commit 2164c3b into Code52:master Mar 23, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment