Add github link to octocat, fixed download animation and paragraph, fixed filesize on paragraph, fixed misbehaved ribbon-inner, fixed text on download button, add space between footer and icon #10

Merged
merged 5 commits into from Jan 11, 2017

Projects

None yet

2 participants

@santosomichael
Contributor

First, thank you for this great opportunity which you gave me. I have spent many weeks since I decide I want to learn to contribute to Open source, what project I could contribute. Somehow I find your awesome page and now I can contribute for the first time, Yeah!!!

  1. Added download button top and bottom notification paragraph, fix animation so it running awesomely
  2. added link to github.com for octocat icon
  3. fixed file size to 1.813 Byte (which is shown on the google chrome download tab), and type show in the paragraph below the button.
  4. fixed misbehaved ribbon-inner because my last update

please send me a feedback if I did something wrong for my future knowledge
Happy new year!!

index.html
@@ -42,6 +42,8 @@
<section id="main_content">
<div class="button">
<a href="http://ginnivan.blob.core.windows.net/carnac/Carnac.application">Download</a>
+ <p class="top">click to begin</p>
+ <p class="bottom">1.813 Byte .application</p>
@shiftkey
shiftkey Jan 8, 2017 Member

This file is just a bootstrapper, which will go and download the necessary files and install the application - it's really small and doesn't quite reflect reality. A more relevant number is the executable's size (3.20MB) - what about if we used that here?

index.html
@@ -42,6 +42,8 @@
<section id="main_content">
<div class="button">
<a href="http://ginnivan.blob.core.windows.net/carnac/Carnac.application">Download</a>
+ <p class="top">click to begin</p>
@shiftkey
shiftkey Jan 8, 2017 Member

I really like this animation, but I'm not quite sure these words are necessary. What if we had something else here?

One idea that comes to mind: we mention this is for Windows, but not which platforms it supports. We could say "requires Windows 7 or later" here instead..

index.html
@@ -62,7 +64,7 @@
<span class="left-tail"></span>
<span class="right-tail"></span>
</span>
- <span class="octocat"></span>
+ <a href="https://github.com/"><span class="octocat"></span></a>
@shiftkey
shiftkey Jan 8, 2017 edited Member

While we're changing this part, do you think you could add some padding between the footer and this icon? Here's a screenshot of how it looks on my side:

@santosomichael santosomichael changed the title from Add github link to octocat, fixed download animation and paragraph, fixed filesize on paragraph, fixed misbehaved ribbon-inner to Add github link to octocat, fixed download animation and paragraph, fixed filesize on paragraph, fixed misbehaved ribbon-inner, fixed text on download button, add space between footer and icon Jan 10, 2017
@shiftkey
Member

@santosomichael that looks good, I'm gonna merge it in which should update the site automagically...

@shiftkey shiftkey merged commit b23b3c3 into Code52:gh-pages Jan 11, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment