Fixed pivot's behavior #27

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
2 participants

Fixed pivot's behavior on item change. It was little buggy, showing annoying horizontal scrollbar.

@shiftkey shiftkey commented on the diff May 29, 2012

index.html
- selectedItemChanged: undefined
- };
-
- $(function () {
- $("div.metro-pivot").metroPivot(defaults);
-
-
- $(".tile").each(addTileTilt);
-
- });
-
-
-
- </script>
- </body>
+<!DOCTYPE html>
@shiftkey

shiftkey May 29, 2012

Owner

The line endings seem to be different now.

Is it just the <script> tag which has been updated?

@dkarbayev

dkarbayev May 29, 2012

Nope, I dunno why git highlighted index.html as changed file. I've only
changed pivot.less and jquery.metro.js files. In 1st file I've added
overflow:hidden property and slightly changed pivot's behavior in js.

С уважением,
Данияр Карбаев

2012/5/29 Brendan Forster <
reply@reply.github.com

  •                         selectedItemChanged: undefined
    

- };

  •                 $(function () {
    

- $("div.metro-pivot").metroPivot(defaults);

- $(".tile").each(addTileTilt);

- });

  •         </script>
    
  • </body>
    
    +

The line endings seem to be different now.

Is it just the <script> tag which has been updated?


Reply to this email directly or view it on GitHub:
https://github.com/Code52/metro.css/pull/27/files#r890622

@shiftkey

shiftkey May 29, 2012

Owner

Ok, I can drop that change from the commit before integrating.

Thanks for the heads up.

On Tue, May 29, 2012 at 7:49 PM, dkarbayev <
reply@reply.github.com

wrote:

  •                         selectedItemChanged: undefined
    

- };

  •                 $(function () {
    

- $("div.metro-pivot").metroPivot(defaults);

- $(".tile").each(addTileTilt);

- });

  •         </script>
    
  • </body>
    
    +

Nope, I dunno why git highlighted index.html as changed file. I've only
changed pivot.less and jquery.metro.js files. In 1st file I've added
overflow:hidden property and slightly changed pivot's behavior in js.

ó Õ×ÁÖÅÎÉÅÍ,
äÁÎÉÑÒ ëÁÒÂÁÅ×

2012/5/29 Brendan Forster <
reply@reply.github.com

  •                         selectedItemChanged: undefined
    

- };

- $(function () {

$("div.metro-pivot").metroPivot(defaults);

- $(".tile").each(addTileTilt);

- });

  •         </script>
    
  • </body>
    
    +

The line endings seem to be different now.

Is it just the <script> tag which has been updated?


Reply to this email directly or view it on GitHub:
https://github.com/Code52/metro.css/pull/27/files#r890622


Reply to this email directly or view it on GitHub:
https://github.com/Code52/metro.css/pull/27/files#r891249

@shiftkey shiftkey pushed a commit that referenced this pull request Jul 6, 2012

@shiftbot shiftbot merged in PR #27 without changes to index.html 498d5ce

shiftkey closed this Jul 6, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment