Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to new project format #324

Closed

Conversation

@biohazard999
Copy link
Contributor

biohazard999 commented Jul 1, 2018

This PR is converting the project from the old csproj style to the new csproj style.

  1. Converted all packages.config references to
  2. Converted to package format
  3. Deleted files that were excluded in the old csproj anyway
  4. Changed the project to use the latest C# compiler
  5. Fixed some warnings that occurred after the project switch

This is the first step of bringing pretzel over to dotnet core. :)

@laedit

This comment has been minimized.

Copy link
Member

laedit commented Jul 1, 2018

Thanks for your interest!
I think the appveyor file needs to be modified to use the Visual Studio 2017 image.

About .net core, sadly there are some parts of Pretzel which use native code, so that will be a bit more difficult.

@biohazard999

This comment has been minimized.

Copy link
Contributor Author

biohazard999 commented Jul 1, 2018

Yeah, missed the appveyor part. Will update the PR later this day.

No doubt that that will be harder. But going to netstandard 2.0 is the first step :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.