Move Pretzel.Logic to multitarget net451/netstandard2.0

[biohazard999]

#320

• This add's support for netstandard20 and net451 for the Pretzel.Logic project.
• Cause MEF is not supported in netstandard20 use System.Composition (MEF2) instead.

This is of course an breaking change for Plugin Authors.

[laedit]

Thanks a lot!

It appears that GitVersion isn't included in Visual Studio 2019 images, so can you edit the appveyor.yml and add the following before the use of GitVersion?

  - choco install gitversion.portable

I will try to review the PR during the wee-end.

[biohazard999]

Thanks a lot!

It appears that GitVersion isn't included in Visual Studio 2019 images, so can you edit the appveyor.yml and add the following before the use of GitVersion?

  - choco install gitversion.portable

Seams there is an issue on GitVersion on VS2019 image so

  - choco install gitversion.portable --version 4.0.0

Did the trick.
Now I need to tackle xunit...

I will try to review the PR during the wee-end.

Thanks! :)

[biohazard999]

@laedit Hmmm could not get the build to working. but I'm not sure whats failing...

[laedit]

Sorry, I didn't get the time to check it this weekend.

The build is weird, I don't see either why it is failing.
Can you try to comment the first line?

$ErrorActionPreference = "Stop"

Maybe it will show more info.

[laedit]

@biohazard999 Sorry to bother you but in order to avoid mixing all things, I will create another PR dedicated to the build fix.
Could you remove any modification related to it in this PR?
Thanks.

[biohazard999]

@biohazard999 Sorry to bother you but in order to avoid mixing all things, I will create another PR dedicated to the build fix.
Could you remove any modification related to it in this PR?
Thanks.

Sure, I'll split it up in two batches if you like.

[laedit]

Sure, I'll split it up in two batches if you like.

No need to, just keep the multi-targets here and I handle the build with #330

[biohazard999]

Ok for the public properties, but yes please revert the classes when possible, thanks.

Configuration was the only class that was internal and exported. So that should be fixed

[laedit]

So I think we are good here, or am I missing something?
I have started to write a small doc with the public differences (for plugins writers mostly) can you tell me if I have forgotten something?
Thanks!

[biohazard999]

So I think we are good here, or am I missing something?
I have started to write a small doc with the public differences (for plugins writers mostly) can you tell me if I have forgotten something?
Thanks!

I think we can overcome this limitation with the convention based model. But for now I think that's it.

You should mention that we moved from

• System.ComponentModel.Composition to System.Composition v1.2.0 for now.
• net451 & netstandard2.0 so they should multitarget in the future as well
• Probably mention as a note that we plan to go net462 to reduce effort.

But I think we are through 😉 Was a hard PR, but I think worth the effort and thanks for your razor sharp eyes 😃

[biohazard999]

@laedit Anything there holing the PR back?

[laedit]

Sorry, didn't get the time to do anything on github today.

Thanks a lot for your hard work! 😄

Next tasks before releasing the next version (not necessarily by you :) )

• target net462 Target net462 #335
• replace ScriptCs Replace ScriptCs by dotnet script #336
• replace other dependencies which doesn't support netstandard Replace dependencies whish doesn't support netstandard #337
• use Cake as build definition Use Cake as build script #329
• make a dotnet global tool Update to net462 #339

[biohazard999]

No worries, I thought you just forgot to merge it 😁