Skip to content
This repository has been archived by the owner. It is now read-only.

Topic/fix xunit warnings #333

Merged
merged 7 commits into from Sep 13, 2019
Merged

Conversation

biohazard999
Copy link
Contributor

@biohazard999 biohazard999 commented Sep 13, 2019

fixes #332

@laedit
Copy link
Member

@laedit laedit commented Sep 13, 2019

Thanks!

There is still a xunit warning on appveyor build:

xUnit1013: Public method 'When' on test class 'SpecificationFor' should be marked as a Fact.

Is it possible to indicate to xunit that this is normal?

@biohazard999
Copy link
Contributor Author

@biohazard999 biohazard999 commented Sep 13, 2019

Thanks!

There is still a xunit warning on appveyor build:

xUnit1013: Public method 'When' on test class 'SpecificationFor' should be marked as a Fact.

Is it possible to indicate to xunit that this is normal?

I can supress it. Adding the [Fact] didn't change it. Seams like a bug in the analyzer

@laedit
Copy link
Member

@laedit laedit commented Sep 13, 2019

Perfect, thanks a lot!

@laedit laedit merged commit e4d949c into Code52:master Sep 13, 2019
1 check passed
@biohazard999 biohazard999 deleted the topic/fix-xunit-warnings branch Sep 13, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants