Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Topic/fix xunit warnings #333

Merged
merged 7 commits into from Sep 13, 2019
Merged

Conversation

@biohazard999
Copy link
Contributor

biohazard999 commented Sep 13, 2019

fixes #332

biohazard999 added 5 commits Sep 4, 2019
Dotliquid sorting (#325)
@laedit

This comment has been minimized.

Copy link
Member

laedit commented Sep 13, 2019

Thanks!

There is still a xunit warning on appveyor build:

xUnit1013: Public method 'When' on test class 'SpecificationFor' should be marked as a Fact.

Is it possible to indicate to xunit that this is normal?

@biohazard999

This comment has been minimized.

Copy link
Contributor Author

biohazard999 commented Sep 13, 2019

Thanks!

There is still a xunit warning on appveyor build:

xUnit1013: Public method 'When' on test class 'SpecificationFor' should be marked as a Fact.

Is it possible to indicate to xunit that this is normal?

I can supress it. Adding the [Fact] didn't change it. Seams like a bug in the analyzer

@laedit

This comment has been minimized.

Copy link
Member

laedit commented Sep 13, 2019

Perfect, thanks a lot!

@laedit laedit merged commit e4d949c into Code52:master Sep 13, 2019
1 check passed
1 check passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
@biohazard999 biohazard999 deleted the biohazard999:topic/fix-xunit-warnings branch Sep 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.