Skip to content
This repository has been archived by the owner. It is now read-only.

Multitarget Pretzel & Pretzel.Tests to net462 & netcoreapp2.2 #345

Merged

Conversation

biohazard999
Copy link
Contributor

@biohazard999 biohazard999 commented Sep 18, 2019

fixes #344

  • App is working on

    • net462
    • netcoreapp2.2
  • Tests are working on

    • net462
    • netcoreapp2.2
    • Appveyor for both platforms

Had to make some changes to the way open cover works (or not)

@laedit Should be ready to review & test

@biohazard999 biohazard999 changed the title Topic/multitarget netcore fullframework 334 Multitarget Pretzel & Pretzel.Tests to net462 & netcoreapp2.2 Sep 18, 2019
@laedit laedit self-requested a review Sep 28, 2019
@laedit laedit added this to In progress in V1.0 - biohazard via automation Sep 28, 2019
laedit
laedit approved these changes Oct 24, 2019
V1.0 - biohazard automation moved this from In progress to Reviewer approved Oct 24, 2019
@laedit laedit merged commit 1744fce into Code52:master Oct 24, 2019
1 check passed
V1.0 - biohazard automation moved this from Reviewer approved to Done Oct 24, 2019
@biohazard999 biohazard999 deleted the topic/multitarget-netcore-fullframework-334 branch Oct 24, 2019
@biohazard999
Copy link
Contributor Author

@biohazard999 biohazard999 commented Oct 24, 2019

Just a quick look on Ubuntu for motivation:

VirtualBox_Ubuntu 18_24_10_2019_14_35_32

@biohazard999
Copy link
Contributor Author

@biohazard999 biohazard999 commented Oct 24, 2019

I am totally impressed:

VirtualBox_Ubuntu 18_24_10_2019_14_40_41

🎉🎉🎉🎉🎉🎉🎉🎉🎉🎉🎉🎉🎉🎉🎉🎉🎉🎉🎉🎉🎉🎉🎉🎉🎉🎉🎉🎉🎉🎉🎉

@laedit
Copy link
Member

@laedit laedit commented Oct 24, 2019

Awesome! :D

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

2 participants