Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Package Pretzel as a global tool #360

Merged
merged 19 commits into from Oct 29, 2019

Conversation

@biohazard999
Copy link
Contributor

biohazard999 commented Oct 24, 2019

Packs Pretzel as a global tool.

relates to #338

@laedit should be ready for review :)

@biohazard999 biohazard999 marked this pull request as ready for review Oct 24, 2019
@laedit laedit self-requested a review Oct 25, 2019
@laedit laedit added this to In progress in V1.0 - biohazard via automation Oct 25, 2019
@laedit

This comment has been minimized.

Copy link
Member

laedit commented Oct 25, 2019

Seems good to me, can you just update appveyor.yml to add Pretzel.Tool in the artifacts and in the nuget deploy?
Since I think dotnet global tools need to be available from nuget, right?

@biohazard999

This comment has been minimized.

Copy link
Contributor Author

biohazard999 commented Oct 25, 2019

Seems good to me, can you just update appveyor.yml to add Pretzel.Tool in the artifacts and in the nuget deploy?
Since I think dotnet global tools need to be available from nuget, right?

So you mean like so? I wasn't aware that you can specify them in appveyor.yml as well

appveyor.yml Outdated Show resolved Hide resolved
V1.0 - biohazard automation moved this from In progress to Review in progress Oct 25, 2019
appveyor.yml Outdated Show resolved Hide resolved
@laedit
laedit approved these changes Oct 29, 2019
V1.0 - biohazard automation moved this from Review in progress to Reviewer approved Oct 29, 2019
@laedit laedit merged commit 0cf4f67 into Code52:master Oct 29, 2019
1 check passed
1 check passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
V1.0 - biohazard automation moved this from Reviewer approved to Done Oct 29, 2019
@biohazard999 biohazard999 deleted the biohazard999:topic/pack-as-global-tool-338 branch Oct 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
2 participants
You can’t perform that action at this time.