Fix Barcode scaling/positioning #241
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ing to be handled by the Width/Height and the renderer (browser). This improves the central positioning of QR Code, before the QR Code depending on the size of the encoded value would have different padding on the right/bottom since the scaling was all in integers.
Contributor
|
I noticed this visual bug, but can't find time to look this deeper, thanks 🥇 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix SVG to have a view box based on the encoding size and enable scaling to be handled by the Width/Height and the renderer (browser).
This improves the central positioning of a QR Code. Before the QR Code, depending on the size of the encoded value, would have different padding on the right/bottom since the scaling was all in integers.