Skip to content

Conversation

@segfault-
Copy link
Contributor

Initial creation of MudTextM3 based on material 3 typography specifications - https://m3.material.io/styles/typography/overview

image image

@mckaragoz
Copy link
Contributor

Thanks for the PR. Have two opinions.

  1. What about using "Typo" and "Size" as parameter names?

  2. We need to arrange API page also for the new component. And in drawer's nav menu, components should be in alphabetical order.

@segfault-
Copy link
Contributor Author

Thanks for the PR. Have two opinions.

  1. What about using "Typo" and "Size" as parameter names?
  2. We need to arrange API page also for the new component. And in drawer's nav menu, components should be in alphabetical order.

I’ll amend my pr with these items

@segfault-
Copy link
Contributor Author

checked in changes based on review, let me know if any additional changes are required

@mckaragoz
Copy link
Contributor

mckaragoz commented Jul 6, 2023

checked in changes based on review, let me know if any additional changes are required

Thanks, really good effort. I would only say, we can enhance the docs. We can seperate typo into groups and users can easily show which ones are Display or Body one with a label.

@mckaragoz
Copy link
Contributor

Sorry i didn't see the second picture. Thanks again 🥇

@mckaragoz mckaragoz merged commit 483f982 into CodeBeamOrg:dev Jul 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants