Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename AssetTransferAddress to AsssetAddress #115

Closed
kseo opened this issue Aug 9, 2018 · 3 comments · Fixed by #362
Closed

Rename AssetTransferAddress to AsssetAddress #115

kseo opened this issue Aug 9, 2018 · 3 comments · Fixed by #362
Labels
discussion

Comments

@kseo
Copy link
Member

kseo commented Aug 9, 2018

I think AssetTransferAddress is too verbose. Why don't we simplify it to AssetAddress? The meaning is still clear.
@sgkim126
Copy link
Contributor

We already have AssetAddress in CodeChain. I think it will be confusing.

@kseo
Copy link
Member Author

kseo commented Aug 10, 2018

@sgkim126 Is AssetAddress exposed to the SDK?

@sgkim126
Copy link
Contributor

There is a no class named AssetAddress, but there are getAssetAddress which returns H256.

codechain-sdk-js/src/core/transaction/AssetMintTransaction.ts

Line 217 in 4a8a79d

getAssetAddress(): H256 {

codechain-sdk-js/src/core/transaction/AssetTransferTransaction.ts

Line 247 in 6227fca

getAssetAddress(index: number): H256 {

@joojis joojis mentioned this issue Mar 29, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
discussion
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Rename AssetTransferAddress to AssetAddress joojis/codechain-sdk-js
2 participants
@sgkim126 @kseo