Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement ICS PoC #105

Closed
majecty opened this issue Jan 16, 2020 · 5 comments
Closed

Implement ICS PoC #105

majecty opened this issue Jan 16, 2020 · 5 comments
Assignees
Labels

Comments

@majecty
Copy link
Contributor

@majecty majecty commented Jan 16, 2020

We are implementing a proof of concept of ICS. Let's build the PoC first and then discuss improvements.

  • Import the ics-poc branch from the CodeChain repository
  • Import "Implement IBC client RPCs PR" from CodeChain (link)
  • Use Toplevel transaction instead of custom action handler. Custom action handler will be removed soon. #122
  • Update light client to use real light client logic
    • Add validator set hash in the header #153
  • Implement Vector commitment
  • Implement Connection #156
  • Implement Channel & Packets #197
  • Implement Relayer #201
  • Implement a test scenario #201

Decisions

We will implement the handler module before the module system is introduced. We will add a wrapper module that wraps the handler API that is written using Rust in Foundry as a module.

Related issues

  • Make a module programmer be able to implement their light client type. #123
@majecty majecty changed the title Implmenet ICS Implment ICS Jan 16, 2020
@majecty majecty changed the title Implment ICS Implement ICS Jan 16, 2020
@junha1

This comment has been minimized.

Copy link
Contributor

@junha1 junha1 commented Jan 16, 2020

So we've already done something about ICS on CodeChain but not a single byte in foundry?

@majecty

This comment has been minimized.

Copy link
Contributor Author

@majecty majecty commented Jan 16, 2020

Yes, we were implementing it in CodeChain.

@junha1

This comment has been minimized.

Copy link
Contributor

@junha1 junha1 commented Jan 16, 2020

Then no more in CodeChain until we completely implement it in foundry first?

@majecty

This comment has been minimized.

Copy link
Contributor Author

@majecty majecty commented Jan 16, 2020

Yes, we will implement it in Foundry first.

@kseo kseo added the ics label Jan 17, 2020
@junha1 junha1 self-assigned this Feb 13, 2020
@junha1 junha1 added the experiment label Feb 27, 2020
@majecty majecty changed the title Implement ICS Implement ICS PoC Mar 12, 2020
@majecty

This comment has been minimized.

Copy link
Contributor Author

@majecty majecty commented Mar 12, 2020

DONE. I added other issues and PR links in the description.

@majecty majecty closed this Mar 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants
You can’t perform that action at this time.