New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement connOpenInit datagram in the ICS connection spec #157
Conversation
f26e693
to
52751f1
Compare
}, | ||
} | ||
|
||
impl Encodable for Datagram { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I changed it. Could you check it again?
core/src/ibc/connection_03/types.rs
Outdated
} | ||
|
||
impl rlp::Encodable for ConnectionEnd { | ||
fn rlp_append(&self, s: &mut rlp::RlpStream) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did you check that RLP macro can handle this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure, I'll check them.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I checked this code: https://github.com/CodeChain-io/rlp/blob/64fdbc5758e05483f62fae99521520f566eaca9d/rlp-derive/src/en.rs#L21
It seems it is suitable to use it. I'll try it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I changed it. Could you check it again?
52751f1
to
ffe6d73
Compare
ffe6d73
to
71c696c
Compare
This PR depends on
#122, #161Implement ICS connection issue: #156