Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement connOpenInit datagram in the ICS connection spec #157

Merged
merged 3 commits into from Feb 13, 2020

Conversation

majecty
Copy link
Contributor

@majecty majecty commented Feb 12, 2020

This PR depends on #122, #161

Implement ICS connection issue: #156

@majecty majecty changed the title [WIP] implement ICS connection Implement ICS connection Feb 12, 2020
@majecty majecty added the ics Interchain standard label Feb 12, 2020
@majecty majecty changed the title Implement ICS connection Implement connOpenInit datagram in the ICS connection spec Feb 12, 2020
},
}

impl Encodable for Datagram {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I changed it. Could you check it again?

}

impl rlp::Encodable for ConnectionEnd {
fn rlp_append(&self, s: &mut rlp::RlpStream) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you check that RLP macro can handle this?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, I'll check them.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I checked this code: https://github.com/CodeChain-io/rlp/blob/64fdbc5758e05483f62fae99521520f566eaca9d/rlp-derive/src/en.rs#L21
It seems it is suitable to use it. I'll try it.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I changed it. Could you check it again?

@majecty majecty merged commit 5ebf5cb into CodeChain-io:ics-poc Feb 13, 2020
@majecty majecty deleted the f/ics-poc-connection branch February 13, 2020 08:17
@junha1 junha1 added the experiment Experimental features label Feb 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
experiment Experimental features ics Interchain standard
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants