From 4930b8bb3804ef3a7b7c5267766dbd485715a975 Mon Sep 17 00:00:00 2001
From: Matt Johnston <matt@codeconstruct.com.au>
Date: Thu, 30 Oct 2025 16:02:29 +0800
Subject: [PATCH] mctp-estack: Don't use async when not needed

Removing async from these functions saves code size.
Add a clippy::unused_async lint.

Signed-off-by: Matt Johnston <matt@codeconstruct.com.au>
---
 mctp-estack/src/lib.rs    |  1 +
 mctp-estack/src/router.rs | 16 ++++++++--------
 2 files changed, 9 insertions(+), 8 deletions(-)

diff --git a/mctp-estack/src/lib.rs b/mctp-estack/src/lib.rs
index 2d07ee2..bde1bff 100644
--- a/mctp-estack/src/lib.rs
+++ b/mctp-estack/src/lib.rs
@@ -34,6 +34,7 @@
 // defmt does not currently allow inline format arguments, so we don't want
 // those reworked when using the log crate either.
 #![allow(clippy::uninlined_format_args)]
+#![warn(clippy::unused_async)]
 
 #[cfg(test)]
 #[macro_use]
diff --git a/mctp-estack/src/router.rs b/mctp-estack/src/router.rs
index d257b80..6744632 100644
--- a/mctp-estack/src/router.rs
+++ b/mctp-estack/src/router.rs
@@ -144,7 +144,7 @@ impl PortTop {
     /// Do not call with locks held.
     /// May block waiting for a port queue to flush.
     /// Packet must be a valid MCTP packet, may panic otherwise.
-    async fn forward_packet(&self, pkt: &[u8]) -> Result<()> {
+    fn forward_packet(&self, pkt: &[u8]) -> Result<()> {
         debug_assert!(MctpHeader::decode(pkt).is_ok());
 
         // With forwarded packets we don't want to block if
@@ -550,7 +550,7 @@ impl<'r> Router<'r> {
             match inner.stack.receive(pkt) {
                 // Complete message
                 Ok(Some(msg)) => {
-                    self.incoming_local(msg).await;
+                    self.incoming_local(msg);
                     return ret_src;
                 }
                 // Fragment consumed, message is incomplete
@@ -577,11 +577,11 @@ impl<'r> Router<'r> {
             return ret_src;
         };
 
-        let _ = top.forward_packet(pkt).await;
+        let _ = top.forward_packet(pkt);
         ret_src
     }
 
-    async fn incoming_local(&self, msg: MctpMessage<'_>) {
+    fn incoming_local(&self, msg: MctpMessage<'_>) {
         trace!("incoming local, type {}", msg.typ.0);
         debug_assert!(
             msg.tag.is_owner() == msg.cookie().is_none(),
@@ -589,13 +589,13 @@ impl<'r> Router<'r> {
         );
 
         if msg.tag.is_owner() {
-            self.incoming_listener(msg).await
+            self.incoming_listener(msg)
         } else {
-            self.incoming_response(msg).await
+            self.incoming_response(msg)
         }
     }
 
-    async fn incoming_listener(&self, mut msg: MctpMessage<'_>) {
+    fn incoming_listener(&self, mut msg: MctpMessage<'_>) {
         // wake the packet listener
         self.app_listeners.lock(|a| {
             let mut a = a.borrow_mut();
@@ -615,7 +615,7 @@ impl<'r> Router<'r> {
         });
     }
 
-    async fn incoming_response(&self, mut msg: MctpMessage<'_>) {
+    fn incoming_response(&self, mut msg: MctpMessage<'_>) {
         if let Some(cookie) = msg.cookie() {
             msg.retain();
             self.recv_wakers.wake(cookie);