Skip to content

🐞 Delete Account button does not work in Accounts Settings #1245

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
austincondiff opened this issue Apr 27, 2023 · 0 comments · Fixed by #1248
Closed

🐞 Delete Account button does not work in Accounts Settings #1245

austincondiff opened this issue Apr 27, 2023 · 0 comments · Fixed by #1248
Labels
bug Something isn't working

Comments

@austincondiff
Copy link
Collaborator

austincondiff commented Apr 27, 2023 •
edited
Loading

Description

The "Delete Account..." button does not work delete an account when confirming.

To Reproduce

  1. Open Settings
  2. Go to Accounts page
  3. If you haven't already, add an account
  4. Click on an account in the list
  5. Click "Delete Account..." button
  6. Confirm when asked

Expected Behavior

The account should be deleted and the user should automatically be navigated back to the Accounts page (with the list of accounts and "Add Account..." button).

Version Information

CodeEdit: 0.0.3-dev (32)

Screenshots

Screen.Recording.2023-04-27.at.1.50.10.PM.mov

Related issues
@austincondiff austincondiff added the bug Something isn't working label Apr 27, 2023
This was referenced Apr 27, 2023
Closed
Closed
@Cubik65536 Cubik65536 mentioned this issue Apr 28, 2023
Merged
6 tasks
@github-project-automation github-project-automation bot moved this from 🆕 New to 🏁 Complete in CodeEdit Project Apr 29, 2023
matthijseikelenboom pushed a commit that referenced this issue Apr 29, 2023
@Cubik65536
fix(AccountsSettingsDetailsView): Fix Delete Account button (#1245) (#…
e39baba 
…1248)

* refactor(AccountsSettingsDetailsView): Replace Deprecated `Alert`

Signed-off-by: Qian Qian "Cubik"‎ <cubik65536@cubik65536.top>

* fix(AccountsSettingsDetailsView): Handle properly account delete

* feat(AccountsSettingsDetailsView): Redirects user back to the accounts list after account delete

* refactor(AccountsSettingsDetailsView): Use `dismiss` instead of deprecated PresentationMode

Signed-off-by: Qian Qian "Cubik"‎ <cubik65536@cubik65536.top>

---------

Signed-off-by: Qian Qian "Cubik"‎ <cubik65536@cubik65536.top>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
CodeEdit Project
Status: 🏁 Complete
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(AccountsSettingsDetailsView): Fix Delete Account button (#1245) Cubik65536/CodeEdit
1 participant
@austincondiff