Skip to content

Made design improvements to About and Acknowledgements windows #1003

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
Jan 20, 2023
Merged

Made design improvements to About and Acknowledgements windows #1003

merged 10 commits into from
Jan 20, 2023

Conversation

austincondiff
Copy link
Collaborator

@austincondiff austincondiff commented Jan 19, 2023 •
edited
Loading

Description

Made design improvements to About and Acknowledgements windows

Checklist

  • I read and understood the contributing guide as well as the code of conduct
  • My changes generate no new warnings
  • My code builds and runs on my machine
  • I documented my code
  • Review requested

Screenshots

About

Before
image

After
image

Acknowledgements

Before
image

After
image

Wouter01
Wouter01 previously approved these changes Jan 19, 2023
View reviewed changes
lukepistrol
lukepistrol requested changes Jan 20, 2023
View reviewed changes
Copy link
Member

@lukepistrol lukepistrol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one last thing to keep the view itself clean.

@austincondiff austincondiff enabled auto-merge (squash) January 20, 2023 01:05
@austincondiff austincondiff merged commit b630973 into CodeEditApp:main Jan 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lukepistrol lukepistrol lukepistrol approved these changes

@thecoolwinter thecoolwinter Awaiting requested review from thecoolwinter

@matthijseikelenboom matthijseikelenboom Awaiting requested review from matthijseikelenboom

@Wouter01 Wouter01 Awaiting requested review from Wouter01

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@austincondiff @matthijseikelenboom @lukepistrol @Wouter01