Improved welcomewindow #1039
Merged
Improved welcomewindow #1039
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Wouter01 <wouterhennen@gmail.com>
Signed-off-by: Wouter01 <wouterhennen@gmail.com>
Signed-off-by: Wouter01 <wouterhennen@gmail.com>
Signed-off-by: Wouter01 <wouterhennen@gmail.com>
Signed-off-by: Wouter01 <wouterhennen@gmail.com>
Signed-off-by: Wouter01 <wouterhennen@gmail.com>
Signed-off-by: Wouter01 <wouterhennen@gmail.com>
Wouter01
requested review from
matthijseikelenboom,
lukepistrol,
thecoolwinter and
austincondiff
and removed request for
matthijseikelenboom and
lukepistrol
|
Can you post a screenshot of the welcome window or is there no visible change to the UI? |
There are no visible changes :) |
austincondiff
previously approved these changes
Feb 20, 2023
0xWDG
previously approved these changes
Feb 20, 2023
Signed-off-by: Wouter01 <wouterhennen@gmail.com>
austincondiff
requested review from
matthijseikelenboom,
0xWDG and
austincondiff
austincondiff
approved these changes
Feb 21, 2023
0xWDG
approved these changes
Feb 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR simplifies the code for the Recent Projects List, adds multiselection behavior to that list, and unifies it with the built-in macOS recent files list.
This solves the problem where the recent files list in the welcome window would differ from the one provided by the system in File -> Open, and CodeEdit Icon -> Right click. The welcome window now gets updated instantly, also when a new project has been openend by e.g. dragging it to the CodeEdit icon in the dock.
Certain list features, like selection multiple items, don't have any lag anymore.
Small extra change: Changed
@NSApplicationMainto@mainin AppDelegate, as the former will be deprecated in the future.Checklist