improvement to window state - #1068
Merged
Merged
Conversation
Signed-off-by: Wouter01 <wouterhennen@gmail.com>
Wouter01
requested review from
austincondiff,
lukepistrol,
matthijseikelenboom and
thecoolwinter
February 20, 2023 03:50
Signed-off-by: Wouter01 <wouterhennen@gmail.com>
Wouter01
enabled auto-merge (squash)
February 20, 2023 03:52
Signed-off-by: Wouter01 <wouterhennen@gmail.com>
austincondiff
previously approved these changes
Feb 20, 2023
0xWDG
previously approved these changes
Feb 20, 2023
0xWDG
left a comment
0xWDG
left a comment
Collaborator
There was a problem hiding this comment.
Please look at Matthijs's comments.
Signed-off-by: Wouter01 <wouterhennen@gmail.com>
austincondiff
previously approved these changes
Feb 21, 2023
austincondiff
approved these changes
Feb 21, 2023
matthijseikelenboom
approved these changes
Feb 21, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR adds a small but worthwile improvement to the app. Previously, if CodeEdit was quit and reopenend, documents would be reopened but without their previous window position (e.g. in fullscreen). By setting
NSQuitAlwaysKeepsWindowsto true, macOS will fix this for us automatically, and the window restoration will behave as if the app is force-quit each time (e.g. when you press the play button in Xcode).Oh, and it also removed the need for a swiftlint:disable comment. Yay!
Checklist
Screenshots
Previous: window position isn't kept on relaunch
https://user-images.githubusercontent.com/62355975/220004956-beddef2f-5a5b-4c7e-985e-be0a25081b8f.mov
New: window position is kept
https://user-images.githubusercontent.com/62355975/220005096-4151c696-3cd1-43e4-bf22-ddb836be9adc.mov