Skip to content

Removed close animations on tabs #1081

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 24, 2023
Merged

Removed close animations on tabs #1081

merged 2 commits into from
Feb 24, 2023

Conversation

maxkel
Copy link
Contributor

@maxkel maxkel commented Feb 24, 2023

Description

Removed animations when closing tabs

Related Issue

Checklist

  • I read and understood the contributing guide as well as the code of conduct
  • My changes generate no new warnings
  • My code builds and runs on my machine
  • I documented my code
  • Review requested

Screenshots

CodeEdit.Remoe.tab.close.animation.mov

austincondiff
austincondiff requested changes Feb 24, 2023
View reviewed changes
Copy link
Collaborator

@austincondiff austincondiff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent work! However the animation still occurs in the tab content when closing. If you notice, when closing a tab the editors have a cross fade transition. Remove that and I can approve.

@maxkel
Copy link
Contributor Author

maxkel commented Feb 24, 2023

OK, here is a video of the new version.

CodeEdit.Remove.TabBar.Close.animation.2.mov

@maxkel maxkel requested review from austincondiff and removed request for 0xWDG, matthijseikelenboom, thecoolwinter and Wouter01 February 24, 2023 16:11
@austincondiff austincondiff merged commit 34727e4 into CodeEditApp:main Feb 24, 2023
@austincondiff
Copy link
Collaborator

@allcontributors add @maxkel for bug

@allcontributors allcontributors bot mentioned this pull request Feb 24, 2023
Merged
@allcontributors
Copy link
Contributor

@austincondiff

I've put up a pull request to add @maxkel! 🎉

@matthijseikelenboom matthijseikelenboom mentioned this pull request Mar 3, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@austincondiff austincondiff austincondiff approved these changes

@Wouter01 Wouter01 Wouter01 approved these changes

@lukepistrol lukepistrol Awaiting requested review from lukepistrol

@matthijseikelenboom matthijseikelenboom Awaiting requested review from matthijseikelenboom

@thecoolwinter thecoolwinter Awaiting requested review from thecoolwinter

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@maxkel @austincondiff @Wouter01