Skip to content

Rename Breadcrumbs to PathBar and fix comments #1113

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 19 commits into from
Mar 10, 2023
Merged

Rename Breadcrumbs to PathBar and fix comments #1113

merged 19 commits into from
Mar 10, 2023

Conversation

@iggy890
Copy link
Contributor

@iggy890 iggy890 commented Mar 5, 2023 •
edited
Loading

Description

This PR fixes a few typos, renames Breadcrumbs to PathBar and adds the opacity setting.

Related Issue

Closes #1105
Closes #1055

Checklist

  • I read and understood the contributing guide as well as the code of conduct
  • My changes generate no new warnings
  • My code builds and runs on my machine
  • I documented my code
  • Review requested

@iggy890 iggy890 changed the title Add opacity support to terminal Add opacity support to terminal and rename Breadcrumbs to PathBar Mar 5, 2023
@iggy890 iggy890 changed the title Add opacity support to terminal and rename Breadcrumbs to PathBar Add opacity support to terminal and rename Breadcrumbs to PathBar Mar 5, 2023
@austincondiff
Copy link
Collaborator

austincondiff commented Mar 5, 2023

What does terminal opacity do? Can you post screenshots or a screen recording?

@iggy890
Copy link
Contributor Author

iggy890 commented Mar 5, 2023

What does terminal opacity do? Can you post screenshots or a screen recording?

Sorry, totally forgot about that I'll upload a screenshot

@iggy890
Copy link
Contributor Author

iggy890 commented Mar 5, 2023

@austincondiff you should be able to see a screenshot now.

@iggy890
Copy link
Contributor Author

iggy890 commented Mar 5, 2023

Basically, higher less opaque/transparent and lower more opaque/transparent

@iggy890
Copy link
Contributor Author

iggy890 commented Mar 5, 2023

I'm soon adding support for cursor styling.

@austincondiff
Copy link
Collaborator

austincondiff commented Mar 5, 2023

I still don't know what it does. Please either post a video demonstrating the feature or explain what this does.

@iggy890
Copy link
Contributor Author

iggy890 commented Mar 5, 2023 •
edited
Loading

@austincondiff Video has been posted.

@iggy890
Copy link
Contributor Author

iggy890 commented Mar 6, 2023

@austincondiff Have you reviewed yet? This is a small PR so it won't take a lot of time to review, maybe if you're unavailable @lukepistrol could take look.

@lukepistrol
Copy link
Member

lukepistrol commented Mar 6, 2023

What exactly is the purpose of terminal opacity? If I wanted a dimmer appearance I could always change the colors anyways.

Please put such changes in a separate PR if it hasn't been discussed yet.

@iggy890
Copy link
Contributor Author

iggy890 commented Mar 6, 2023 •
edited
Loading

What exactly is the purpose of terminal opacity? If I wanted a dimmer appearance I could always change the colors anyways.

This is step 1 in a two step process step 1 is making the text opaque and step 2 is making the terminal background opaque. If you want it done in one big PR I'll happily do that.

@austincondiff
Copy link
Collaborator

austincondiff commented Mar 6, 2023 •
edited
Loading

Unrelated changes (especially ones not captured in an issue) ideally do not belong in the same PR. We do this because if there is a problem with one of the features, we cannot merge until the other is resolved or fixed (if it is at all). If you want terminal opacity, we can discuss it in Discord or GitHub discussions.

@iggy890
Copy link
Contributor Author

iggy890 commented Mar 6, 2023 •
edited
Loading

Unrelated changes (especially ones not captured in an issue) do not belong in the same PR. We do this because if there is a problem with one of the features, we cannot merge until the other is resolved or fixed (if it is at all). If you want terminal opacity, we can discuss it in Discord or GitHub discussions.

Ok, I'll revert a few changes and (later) submit a new PR with a fully working approach towards Terminal Opacity

@iggy890
Copy link
Contributor Author

iggy890 commented Mar 6, 2023

Changes should be reverted.

@iggy890 iggy890 changed the title Add opacity support to terminal and rename Breadcrumbs to PathBar Rename Breadcrumbs to PathBar Mar 6, 2023
@iggy890
Copy link
Contributor Author

iggy890 commented Mar 6, 2023

@austincondiff everything should be resolved

@austincondiff
Copy link
Collaborator

austincondiff commented Mar 6, 2023

Looks much better. FYI, we will be waiting until #1080 is merged to review this PR as it will need to be merged with the latest changes after it is.

@iggy890
Copy link
Contributor Author

iggy890 commented Mar 6, 2023

Looks much better. FYI, we will be waiting until #1080 is merged to review this PR as it will need to be merged with the latest changes after it is.

Don't worry @Wouter01 told me about this yesterday.

@lukepistrol lukepistrol mentioned this pull request Mar 6, 2023
Closed
5 tasks
@iggy890 iggy890 changed the title Rename Breadcrumbs to PathBar Rename Breadcrumbs to PathBar and fix comments Mar 7, 2023
@iggy890 iggy890 mentioned this pull request Mar 7, 2023
Merged
5 tasks
@iggy890 iggy890 closed this Mar 9, 2023
@iggy890 iggy890 reopened this Mar 9, 2023
@austincondiff austincondiff requested a review from 0xWDG March 9, 2023 20:54
@iggy890
Copy link
Contributor Author

iggy890 commented Mar 9, 2023

I'll be offline tonight, but maintainers have edit access, so hopefully you can resolve any more issues you find.

austincondiff
austincondiff previously approved these changes Mar 9, 2023
View reviewed changes
@iggy890 iggy890 requested review from austincondiff and removed request for 0xWDG, Wouter01, lukepistrol and matthijseikelenboom March 9, 2023 21:42
@iggy890
Copy link
Contributor Author

iggy890 commented Mar 9, 2023

Didn't mean to remove those reviewers!

Scrap and others added 3 commits March 10, 2023 00:40
@lukepistrol
Added setting to change font size, so can now change the default font… (
9b2aa31 
#1128)

Added setting to change font size, so can now change the default font size.
@allcontributors @lukepistrol
docs: add scrapp08 as a contributor for code (#1130)
4dd6db1 
* docs: update README.md [skip ci]

* docs: update .all-contributorsrc [skip ci]

---------

Co-authored-by: allcontributors[bot] <46447321+allcontributors[bot]@users.noreply.github.com>
@lukepistrol
Merge branch 'main' into iggy890/main
965fd04
@lukepistrol lukepistrol requested a review from Wouter01 March 9, 2023 23:44
@lukepistrol lukepistrol added documentation Improvements or additions to documentation breadcrumbs labels Mar 9, 2023
@austincondiff austincondiff merged commit 281b298 into CodeEditApp:main Mar 10, 2023
@CodeEditApp CodeEditApp deleted a comment from allcontributors bot Mar 10, 2023
@austincondiff
Copy link
Collaborator

austincondiff commented Mar 10, 2023

@allcontributors add @iggy890 for code

@allcontributors allcontributors bot mentioned this pull request Mar 10, 2023
Merged
@allcontributors
Copy link
Contributor

allcontributors bot commented Mar 10, 2023

@austincondiff

I've put up a pull request to add @iggy890! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@austincondiff austincondiff austincondiff approved these changes

@lukepistrol lukepistrol lukepistrol approved these changes

@Wouter01 Wouter01 Wouter01 approved these changes

Assignees

No one assigned

Labels

breadcrumbs documentation Improvements or additions to documentation

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

🧹 Rename all references of "Breadcrumbs Bar" to "Path Bar" 🐞 Key Bindings is just "Hello World"

4 participants

@iggy890 @austincondiff @lukepistrol @Wouter01