Overlay UI Improvements #1159
Merged
Overlay UI Improvements #1159
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Lukas Pistrol <l.pistrol@gmail.com>
Co-authored-by: Lukas Pistrol <l.pistrol@gmail.com>
…oks right. Other UI corrections to improve the design of the overlay.
Signed-off-by: Wouter01 <wouterhennen@gmail.com>
Signed-off-by: Wouter01 <wouterhennen@gmail.com>
Signed-off-by: Wouter01 <wouterhennen@gmail.com>
…enamed queryContent to text. Added alwaysShowOptions parameter. Added optionRowHeight parameter. Showing commands by default when there is no text in command palette.
… out in open quickly overlay
austincondiff
force-pushed
the
open-quicly-fixes
branch
from
ceac385 to
cb6e01b
Compare
…and pallet to ⌘⇧P
austincondiff
requested review from
lukepistrol,
0xWDG,
KaiTheRedNinja,
thecoolwinter and
Wouter01
|
@lukepistrol can we can a new release of CodeEditTextView so this can be merged when approved? |
Wouter01
previously approved these changes
Mar 20, 2023
|
@austincondiff just created a |
lukepistrol
previously approved these changes
Mar 20, 2023
austincondiff
dismissed stale reviews from lukepistrol and Wouter01
via
42ce1d3
Signed-off-by: Wouter01 <wouterhennen@gmail.com>
Wouter01
approved these changes
Mar 20, 2023
lukepistrol
approved these changes
Mar 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Refactored open quickly overlay UI to match designs more closely.
Note: I had to change how our text view was setting editable. If this was false it would simply use a disabled modifier on the text view. This did prevent editing however it also disabled scrolling as well. So in https://github.com/CodeEditApp/CodeEditTextView/pull/161 I am adding
isEditable, a variable used by STTextView, in CodeEditTextView used for this very purpose.Related Issues
Prerequisites
https://github.com/CodeEditApp/CodeEditTextView/pull/161 needs to be merged before this is merged.
Checklist
Additional Considerations
CodeEditTextView will need a new release before this is merged. Tests are failing because the
isEditableparameter was added and used which does not exist in the latest release.Screenshots
Command Palette
Open Quickly
