Skip to content

Add setting to determine what happens after closing the last open workspace #1194

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Mar 24, 2023

Conversation

luah5
Copy link
Member

@luah5 luah5 commented Mar 23, 2023

Description

this PR adds a preference for what happens after a workspace is closed. the options are:

  • Do nothing
  • Show welcome window
  • Quit

Related Issues

Checklist

  • I read and understood the contributing guide as well as the code of conduct
  • The issues this PR addresses are related to each other
  • My changes generate no new warnings
  • My code builds and runs on my machine
  • My changes are all related to the related issue above
  • I documented my code

Screenshots and recordings

smaller.mov

Copy link
Member

@Wouter01 Wouter01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job! The current implementation seems to work, however I think it might be a good idea to generalize it more. Instead of "after the last workspace is closed", we could do "after the last window is closed". For example, if a user has no workspaces open, but it has some other window open (Settings, About, maybe later on some other window). What should happen in that case?

@luah5
Copy link
Member Author

luah5 commented Mar 23, 2023

Good job! The current implementation seems to work, however I think it might be a good idea to generalize it more. Instead of "after the last workspace is closed", we could do "after the last window is closed". For example, if a user has no workspaces open, but it has some other window open (Settings, About, maybe later on some other window). What should happen in that case?

thanks for the review! I only intend the welcome window to open when a workspace/file (as you pointed out) is closed, i could very easily add this feature but i think it's not necessary (unless you think otherwise).

Copy link
Member

@lukepistrol lukepistrol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe use a switch case since it is easier to maintain

@luah5 luah5 requested review from lukepistrol and Wouter01 and removed request for lukepistrol March 23, 2023 19:56
Wouter01
Wouter01 previously approved these changes Mar 23, 2023
@Wouter01 Wouter01 self-requested a review March 23, 2023 20:16
@austincondiff
Copy link
Collaborator

@luah5 Can you post screen recording of it working or at a minimum a screenshot of the settings with the picker?

@luah5
Copy link
Member Author

luah5 commented Mar 23, 2023

@luah5 Can you post screen recording of it working or at a minimum a screenshot of the settings with the picker?

sure!

@luah5 luah5 requested a review from austincondiff March 23, 2023 21:10
Copy link
Collaborator

@austincondiff austincondiff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!

@lukepistrol lukepistrol merged commit 495b8dd into CodeEditApp:main Mar 24, 2023
@austincondiff
Copy link
Collaborator

@allcontributors add @luah5 for code

@allcontributors
Copy link
Contributor

@austincondiff

I've put up a pull request to add @luah5! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

✨ Setting to determine what happens after closing the last open window
5 participants