-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Add setting to determine what happens after closing the last open workspace #1194
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good job! The current implementation seems to work, however I think it might be a good idea to generalize it more. Instead of "after the last workspace is closed", we could do "after the last window is closed". For example, if a user has no workspaces open, but it has some other window open (Settings, About, maybe later on some other window). What should happen in that case?
thanks for the review! I only intend the welcome window to open when a workspace/file (as you pointed out) is closed, i could very easily add this feature but i think it's not necessary (unless you think otherwise). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe use a switch case since it is easier to maintain
CodeEdit/Features/Documents/Controllers/CodeEditDocumentController.swift
Outdated
Show resolved
Hide resolved
…d add switch resolves @lukepistrol review
@luah5 Can you post screen recording of it working or at a minimum a screenshot of the settings with the picker? |
sure! |
CodeEdit/Features/AppPreferences/Sections/GeneralPreferences/GeneralPreferencesView.swift
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work!
@allcontributors add @luah5 for code |
I've put up a pull request to add @luah5! 🎉 |
Description
this
PR
adds a preference for what happens after a workspace is closed. the options are:Related Issues
Checklist
Screenshots and recordings
smaller.mov