Skip to content

Add pixel to top of first line - #1229

Merged
austincondiff merged 1 commit into
CodeEditApp:mainfrom
evanlwang:main
Apr 12, 2023
Merged

Add pixel to top of first line#1229
austincondiff merged 1 commit into
CodeEditApp:mainfrom
evanlwang:main

Conversation

@evanlwang

@evanlwang evanlwang commented Apr 12, 2023

Copy link
Copy Markdown
Contributor

Description

This PR adds a single pixel to the top of the first line so there is a space between the highlight color and the divider of the path bar.

Related Issues

Checklist

  • I read and understood the contributing guide as well as the code of conduct
  • The issues this PR addresses are related to each other
  • My changes generate no new warnings
  • My code builds and runs on my machine
  • My changes are all related to the related issue above
  • I documented my code

Screenshots

Before
Screenshot 2023-04-12 at 12 04 41 AM

After
Screenshot 2023-04-12 at 12 03 40 AM

@evanlwang
evanlwang marked this pull request as ready for review April 12, 2023 04:12
@evanlwang

Copy link
Copy Markdown
Contributor Author

How would I go about documenting my code?

@evanlwang evanlwang changed the title Add pixel to first line Add pixel to top of first line Apr 12, 2023
@austincondiff

Copy link
Copy Markdown
Collaborator

Documentation may not be terribly applicable here.

@austincondiff austincondiff left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! 👍

@austincondiff
austincondiff merged commit cd8d91a into CodeEditApp:main Apr 12, 2023
@austincondiff

Copy link
Copy Markdown
Collaborator

@allcontributors add @evanlwang for code.

@allcontributors

Copy link
Copy Markdown
Contributor

@austincondiff

I've put up a pull request to add @evanlwang! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

✨ Add one pixel of padding above first line

3 participants