Skip to content

Add Missing Text View Settings #1271

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
May 22, 2023

Conversation

thecoolwinter
Copy link
Collaborator

Description

This implements a few settings for parameters available in CodeEditTextView that haven't been made available yet in CodeEdit:

  • Indent Options, whether to space or tab on a tab key press
  • Bracket Highlights, when the user's cursor is next to a bracket highlight the opposite pair or both brackets.

Related Issues

  • N/A

Checklist

  • I read and understood the contributing guide as well as the code of conduct
  • The issues this PR addresses are related to each other
  • My changes generate no new warnings
  • My code builds and runs on my machine
  • My changes are all related to the related issue above
  • I documented my code

Screenshots

Bracket Pair Highlighting:

flash.mov

Indent Options:

indent.mov

@austincondiff austincondiff self-requested a review May 20, 2023 16:23
austincondiff
austincondiff previously approved these changes May 20, 2023
Copy link
Collaborator

@austincondiff austincondiff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice @thecoolwinter. Nothing needs to be done now, but as a small note, in the future we will want to use standard colors from the system and theme for the bracket highlight color. Looks great!

0xWDG
0xWDG previously approved these changes May 22, 2023
Copy link
Collaborator

@0xWDG 0xWDG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM;

Please note the conflict in CodeEdit.xcodeproj/project.pbxproj.

@austincondiff austincondiff dismissed stale reviews from 0xWDG and themself via fa863f6 May 22, 2023 06:09
@austincondiff austincondiff merged commit d20b025 into CodeEditApp:main May 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants