Add Missing Text View Settings - #1271
Merged
austincondiff merged 4 commits intoMay 22, 2023
Merged
Conversation
austincondiff
self-requested a review
May 20, 2023 16:23
austincondiff
previously approved these changes
May 20, 2023
austincondiff
left a comment
Collaborator
There was a problem hiding this comment.
Very nice @thecoolwinter. Nothing needs to be done now, but as a small note, in the future we will want to use standard colors from the system and theme for the bracket highlight color. Looks great!
0xWDG
previously approved these changes
May 22, 2023
0xWDG
left a comment
Collaborator
There was a problem hiding this comment.
LGTM;
Please note the conflict in CodeEdit.xcodeproj/project.pbxproj.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This implements a few settings for parameters available in CodeEditTextView that haven't been made available yet in CodeEdit:
Related Issues
Checklist
Screenshots
Bracket Pair Highlighting:
flash.mov
Indent Options:
indent.mov