Fix Settings color picker - #1277
Merged
matthijseikelenboom merged 3 commits intoMay 29, 2023
Merged
Conversation
…changes separately. Simplify Color extension on hexString
matthijseikelenboom
requested review from
0xWDG,
KaiTheRedNinja,
Wouter01,
austincondiff,
lukepistrol,
matthijseikelenboom and
thecoolwinter
May 25, 2023 12:29
matthijseikelenboom
previously approved these changes
May 29, 2023
0xWDG
previously approved these changes
May 29, 2023
0xWDG
left a comment
0xWDG
left a comment
Collaborator
There was a problem hiding this comment.
LGTM, please fix the comment as matthijseikelenboom already said.
defaultdino
dismissed stale reviews from 0xWDG and matthijseikelenboom
via
May 29, 2023 16:17
3ee1901
0xWDG
approved these changes
May 29, 2023
matthijseikelenboom
approved these changes
May 29, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add local state and onChange to SettingsColorPicker, to handle theme changes separately. Simplify Color extension on hexString
Description
I changed the SettingsColorPicker.swift and Color+HEX.swift. The SettingsColorPicker now has local state handling the color of the picker, and any change to this triggers a theme update via the passed binding. Prior implementation caused undefined behavior and sporadic color picker changes.
Changes to Color+HEX extension were only simplifications of existing code.
Related Issues
Checklist
Screenshots
Colorpicker.mp4