Skip to content

refactor: Refactor font changes codes in ViewCommands #1285

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
May 29, 2023
Merged

refactor: Refactor font changes codes in ViewCommands #1285

merged 5 commits into from
May 29, 2023

Conversation

Qubik65536
Copy link
Contributor

Description

  • Allow font changes command to change terminal font sizes
  • Disable font changing if no workspace window is open
  • Prevent font size from going over the max value (288)

Related Issues

  • N/A

Checklist

  • I read and understood the contributing guide as well as the code of conduct
  • The issues this PR addresses are related to each other
  • My changes generate no new warnings
  • My code builds and runs on my machine
  • My changes are all related to the related issue above
  • I documented my code

Screenshots

N/A

Qubik65536 added 5 commits May 27, 2023 18:41
@Qubik65536
refactor: Add command to change terminal font size
3e00eb6 
Signed-off-by: Qian Qian "Cubik"‎ <cubik65536@cubik65536.top>
@Qubik65536
refactor(ViewCommands): Use more specific @AppSettings
59c3286 
Signed-off-by: Qian Qian "Cubik"‎ <cubik65536@cubik65536.top>
@Qubik65536
feat: Disable font size adjustment if no opened workspace
9852eab 
Signed-off-by: Qian Qian "Cubik"‎ <cubik65536@cubik65536.top>
@Qubik65536
fix: Prevent font size to go over max value (288)
7ebf6a6 
Signed-off-by: Qian Qian "Cubik"‎ <cubik65536@cubik65536.top>
@Qubik65536
refactor(ViewCommands): Remove unused CodeEditDocumentController
bd808a7 
Signed-off-by: Qian Qian "Cubik"‎ <cubik65536@cubik65536.top>
@Wouter01 Wouter01 added the bug Something isn't working label May 29, 2023
@Wouter01 Wouter01 merged commit e73b510 into CodeEditApp:main May 29, 2023
@Qubik65536 Qubik65536 deleted the patch-terminal-fontsize-change-command branch June 3, 2023 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xWDG 0xWDG 0xWDG approved these changes

@Wouter01 Wouter01 Wouter01 approved these changes

@austincondiff austincondiff Awaiting requested review from austincondiff

@matthijseikelenboom matthijseikelenboom Awaiting requested review from matthijseikelenboom

Assignees

@Qubik65536 Qubik65536

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Qubik65536 @0xWDG @Wouter01