Skip to content

Move change theme listener from code file to workspace - #1330

Merged
austincondiff merged 2 commits into
CodeEditApp:mainfrom
dvandyy:match-theme
Jun 18, 2023
Merged

Move change theme listener from code file to workspace#1330
austincondiff merged 2 commits into
CodeEditApp:mainfrom
dvandyy:match-theme

Conversation

@dvandyy

@dvandyy dvandyy commented Jun 18, 2023

Copy link
Copy Markdown
Contributor

Description

Currently is onChange event attached to CodeFileView.
If no editor is open & "Automatically change theme based on system appearance" is set, theme is not changing.
Maybe move this to workspace ?

Related Issues

Checklist

  • I read and understood the contributing guide as well as the code of conduct
  • The issues this PR addresses are related to each other
  • My changes generate no new warnings
  • My code builds and runs on my machine
  • My changes are all related to the related issue above
  • I documented my code

@Wouter01
Wouter01 self-requested a review June 18, 2023 17:49

@Wouter01 Wouter01 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch!
You're right, this is better moved to the workspace level. Leaving it in the WorkspaceTabGroupView might cause issues with split editors. Could you modify your PR for this?

@dvandyy

dvandyy commented Jun 18, 2023

Copy link
Copy Markdown
Contributor Author

@Wouter01 is this okay ?

@Wouter01

Copy link
Copy Markdown
Member

@Wouter01 is this okay ?

Yes, thank you!

@austincondiff
austincondiff self-requested a review June 18, 2023 20:13

@austincondiff austincondiff left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Good catch!

@austincondiff
austincondiff merged commit 76db478 into CodeEditApp:main Jun 18, 2023
@austincondiff

Copy link
Copy Markdown
Collaborator

@allcontributors add @dvandyy for bug

@allcontributors

Copy link
Copy Markdown
Contributor

@austincondiff

I've put up a pull request to add @dvandyy! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

3 participants