Skip to content

Removed closing animation for the tabs - #1383

Merged
thecoolwinter merged 1 commit into
CodeEditApp:mainfrom
FastestMolasses:close-animate
Jul 19, 2023
Merged

Removed closing animation for the tabs#1383
thecoolwinter merged 1 commit into
CodeEditApp:mainfrom
FastestMolasses:close-animate

Conversation

@FastestMolasses

Copy link
Copy Markdown
Member

Description

Removes the animation when closing a file to be like Xcode.

Related Issues

Closes #1073

Checklist

  • I read and understood the contributing guide as well as the code of conduct
  • The issues this PR addresses are related to each other
  • My changes generate no new warnings
  • My code builds and runs on my machine
  • My changes are all related to the related issue above
  • I documented my code

Screenshots

The current animation when closing tabs:
animation

How it looks now:
no-animation

@austincondiff
austincondiff requested a review from a team July 18, 2023 02:20

@austincondiff austincondiff left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I've been meaning to do that for a while! 😄

@thecoolwinter thecoolwinter left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks!

@thecoolwinter
thecoolwinter merged commit 1b5fc2b into CodeEditApp:main Jul 19, 2023
@FastestMolasses
FastestMolasses deleted the close-animate branch July 19, 2023 04:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

🐞 Tabs animate incorrectly

3 participants