Fix visual issues with dragging AreaTabBar icons #1435
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
austincondiff
requested review from
Wouter01,
austincondiff,
matthijseikelenboom and
thecoolwinter
thecoolwinter
approved these changes
Sep 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I updated the Views that use an AreaTabBar to use a ViewModel that is observed and updated properly when dragging an icon. I also clipped the AreaTabBar so that the icons cannot be dragged outside of it. There has also been some renaming and some code cleanup.
Related Issues
Closes #1434
Checklist
Screenshots
Icon Dragging Old:
Icon Dragging New:
Icon Clip Old:
Icon Clip New:
