Skip to content

Fixes Welcome Window on macOS Sonoma - #1446

Merged
austincondiff merged 2 commits into
CodeEditApp:mainfrom
avinizhanov:fix-1445-welcome-window-does-not-open
Oct 13, 2023
Merged

austincondiff merged 2 commits into
CodeEditApp:mainfrom
avinizhanov:fix-1445-welcome-window-does-not-open

Conversation

@avinizhanov

Copy link
Copy Markdown
Contributor

Description

Currently app tries to open welcome window which is already in NSApp.windows.
Added focus on welcome window if it exists in NSApp.windows

Related Issues

Checklist

  • I read and understood the contributing guide as well as the code of conduct
  • The issues this PR addresses are related to each other
  • My changes generate no new warnings
  • My code builds and runs on my machine
  • My changes are all related to the related issue above
  • I documented my code

Checks if welcome window already exists in NSApp and tries to focus on it
@austincondiff
austincondiff self-requested a review October 13, 2023 04:54
austincondiff
austincondiff previously approved these changes Oct 13, 2023
@avinizhanov

Copy link
Copy Markdown
Contributor Author

I missed trailing spacing warnings, fixed them

@austincondiff austincondiff left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@austincondiff
austincondiff merged commit 08f7f1a into CodeEditApp:main Oct 13, 2023
@austincondiff

Copy link
Copy Markdown
Collaborator

@all-contributors add @avinizhanov for bug

@allcontributors

Copy link
Copy Markdown
Contributor

@austincondiff

@avinizhanov already contributed before to bug

@allcontributors

Copy link
Copy Markdown
Contributor

@austincondiff

I've put up a pull request to add @avinizhanov! 🎉

@austincondiff

Copy link
Copy Markdown
Collaborator

@avinizhanov someone in our Discord server just left this message. You have any idea what this is about?

@thecoolwinter thecoolwinter added the bug Something isn't working label Dec 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants