Skip to content

Conversation

@tom-ludwig
Copy link
Member

@tom-ludwig tom-ludwig commented May 24, 2024

Description

This PR fixes some memory leaks that occurred during the retrieval of search results from SearchKit. This was because I wrongfully used .takeUnretainedValue(), which caused the memory count to be off, leading to thousands of objects not being deinitialized.

I reviewed all the code that uses SearchKit and corrected other instances of wrongful use of .takeUnretainedValue() or .takeRetainedValue().

During profiling, there should no longer be any memory leaks connected to SearchKit.

Related Issues

Checklist

  • I read and understood the contributing guide as well as the code of conduct
  • The issues this PR addresses are related to each other
  • My changes generate no new warnings
  • My code builds and runs on my machine
  • My changes are all related to the related issue above
  • I documented my code

Screenshots

@thecoolwinter thecoolwinter merged commit aa7454e into CodeEditApp:main May 24, 2024
@thecoolwinter thecoolwinter added the bug Something isn't working label Jul 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

🐞Memory Leaks in SearchKit Result Retrieval

6 participants