Feature/save example screener UI#423
Merged
Merged
Conversation
Collaborator
|
@joshwanf is this ready? (looks like it hasn't been updated since we last talked, but wanted to make sure) |
…aged resource on prod using manifest.json.
Collaborator
Author
|
Just pushed changes to how the Example Screener service works.
|
getResourceAsStream returns null (not an exception) when a classpath resource is not found. Without this check, callers would receive a null InputStream and encounter an NPE when trying to read from it. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…ortService The configuredSeedPath constructor parameter was injected via @ConfigProperty but never stored or used after the refactor to classpath-based resource loading. Also removes the now-unused ConfigProperty and Optional imports. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
prestoncabe
force-pushed
the
feature/save-example-screener-ui
branch
from
f0733c8 to
e529a9d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
./seed-datainto./builder-api/src/main/resourcesand changed how seed data is read (raw file path vs classpath). There was a bug where production only copies./builder-api(cannot see./seed-data) and the packaged app cannot access normal file paths like it does in developmentExampleScreenerExportServiceand an "Export Example Screener" button in the frontend. After changing the example screener(s) through the UI, this behavior will export all Firestore documents into./builder-api/src/main/resources(overwriting the directory). Pushing to Github lets us diff the changes.