Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[lambda_api_ses] Added basic configuration for AWS Lambda + API Gateway + Role #2

Open
wants to merge 1 commit into
base: master
from

Conversation

@Maciek246
Copy link

commented Jul 10, 2019

No description provided.

@arturtamborski
Copy link

left a comment

It's a pretty big change, I couldn't test it completely, but I believe it should be OK :)

# to deploy from this template:

"bucket" =
"key" = "terraform/Infrastructure/<name-of-environment>.tfstate"

This comment has been minimized.

Copy link
@arturtamborski

arturtamborski Aug 9, 2019

Improvement: We could use terraform workspaces instead of hardcoding this
https://www.terraform.io/docs/state/workspaces.html


provisioner "local-exec"{
command = <<COMMAND
rm -rf ${data.archive_file.lambda_zip.output_path}

This comment has been minimized.

Copy link
@arturtamborski

arturtamborski Aug 9, 2019

do we need -r for lambda.zip? It's just one file.

@@ -0,0 +1,36 @@
terraform {

This comment has been minimized.

Copy link
@arturtamborski

arturtamborski Aug 9, 2019

Nitpick: This looks like tf 0.11 syntax which is OK but (as an improvement) we could use 0.12.
Though I'd also recommend using tfenv for pinning code to specific version of terraform which is not always backward compatible.
[1] https://github.com/tfutils/tfenv

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.