Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Groups #293

Merged
merged 6 commits into from Aug 10, 2019

Conversation

@adamgajzlerowicz
Copy link
Contributor

commented Aug 6, 2019

  • Added groups
  • Assigned current users to Driver group
  • Added route based permissions to routes (driver on all of them for now)

@adamgajzlerowicz adamgajzlerowicz requested review from magul and m-recz Aug 6, 2019

@adamgajzlerowicz adamgajzlerowicz force-pushed the adamgajzlerowicz:groups branch from f77ed4c to 18fcc9d Aug 6, 2019

adamgajzlerowicz added some commits Aug 6, 2019

@adamgajzlerowicz adamgajzlerowicz changed the title Groups [WIP] Groups Aug 6, 2019

@adamgajzlerowicz adamgajzlerowicz changed the title [WIP] Groups Groups Aug 6, 2019

docker-compose.yml Outdated Show resolved Hide resolved
docker-compose.yml Outdated Show resolved Hide resolved
backend/fleet_management/permissions.py Show resolved Hide resolved


def create_groups(apps, schema_editor):
with connections['default'].cursor() as cursor:

This comment has been minimized.

Copy link
@arturtamborski

arturtamborski Aug 9, 2019

Contributor

This line is not needed after my suggestion, can you remove it and indent the lines below to the left? Thanks!

This comment has been minimized.

Copy link
@adamgajzlerowicz

adamgajzlerowicz Aug 9, 2019

Author Contributor

👍

@arturtamborski
Copy link
Contributor

left a comment

Almost good, just one small change.

@adamgajzlerowicz adamgajzlerowicz merged commit 155a5fb into CodeForPoznan:develop Aug 10, 2019

1 check passed

Travis CI - Pull Request Build Passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.