Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle unique validation error with specific HTTP status code earlier (fixes #289) #303

Merged
merged 1 commit into from Aug 9, 2019

Conversation

@magul
Copy link
Member

commented Aug 8, 2019

As CONFLICT (previously UNPROCESSABLE_ENTITY) is connected only with creation for Drive,
there's no reson to not handle it in is_valid method of Drive serializer and leave
excemtion_handler only for final tunning of exceptional response.

@magul magul changed the title Handle unique validation error with specific HTTP status code earlier Handle unique validation error with specific HTTP status code earlier (fixes #289) Aug 8, 2019

@magul magul force-pushed the magul:handle-unique-constrait branch from 0d5a052 to e49f1e5 Aug 9, 2019

.travis.yml Outdated Show resolved Hide resolved
Handle unique validation error with specific HTTP status code earlier
As CONFLICT (previously UNPROCESSABLE_ENTITY) is connected only with creation for Drive,
there's no reson to not handle it in is_valid method of Drive serializer and leave
excemtion_handler only for final tunning of exceptional response.

@magul magul force-pushed the magul:handle-unique-constrait branch from e49f1e5 to c60f0a3 Aug 9, 2019

@magul magul merged commit 6548bc2 into CodeForPoznan:develop Aug 9, 2019

1 check passed

Travis CI - Pull Request Build Passed
Details

@magul magul deleted the magul:handle-unique-constrait branch Aug 9, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.