Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix behave tests #358

Merged
merged 6 commits into from Nov 5, 2019

Conversation

@kruczyna
Copy link
Contributor

kruczyna commented Oct 23, 2019

Refactored login test cases, renamed pah_behave folder and made initial file organization

kruczynakruka added 3 commits Oct 2, 2019
@Maciek246

This comment has been minimized.

Copy link

Maciek246 commented Oct 23, 2019

Please, be consistent in type hints - remove all or add missing (I recommend)

@arturtamborski arturtamborski referenced this pull request Oct 30, 2019
@arturtamborski

This comment has been minimized.

Copy link
Contributor

arturtamborski commented Nov 4, 2019

@kruczyna thanks for addressing to my suggested changes but I don't see your updated code in here. Have you pushed to correct branch? Last commit in this PR is Create first Behave feature which I'm guessing is not the one with fixes.

@arturtamborski arturtamborski merged commit 7cda8a2 into CodeForPoznan:develop Nov 5, 2019
1 check passed
1 check passed
Travis CI - Pull Request Build Passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.