Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

442 Update SQL statement. #443

Conversation

@Ctilhs
Copy link
Contributor

Ctilhs commented Mar 4, 2020

Fix #442

@Ctilhs Ctilhs requested a review from arturtamborski Mar 4, 2020
@Ctilhs

This comment has been minimized.

Copy link
Contributor Author

Ctilhs commented Mar 4, 2020

Waiting for answer here #442

@arturtamborski

This comment has been minimized.

Copy link
Contributor

arturtamborski commented Mar 4, 2020

The numbers you've inserted there for rsa key are incorrect. They are not prime and the public exponent differs from the one defined in settings which would mean that every computation, even with correct key, would fail.

I much rather would like to see a proper rsa key there, but that is not needed anyway, because why would we want raw sql queries here to update stuff in the table if we have python, models and factories :)

Anyway, go on and remove this file along with its directory and mention in Readme. It's not needed anymore, we have make populate-database for that purpose.

@Ctilhs

This comment has been minimized.

Copy link
Contributor Author

Ctilhs commented Mar 4, 2020

Good point with RSA elements @arturtamborski 👍

I removed redundant stuff.

@arturtamborski arturtamborski merged commit 7813159 into CodeForPoznan:develop Mar 4, 2020
1 check passed
1 check passed
Travis CI - Pull Request Build Passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

2 participants
You can’t perform that action at this time.