fix: response.write() to return a bool (resolves #683) #702
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Returning 'false'y tells the sender they need to wait for the 'drain' event which can cause middleware to hang (eg. SvelteKit adapter-node and trpc) Original fix from @KATT in KATT@9ba260e
brettstack
approved these changes
Dec 7, 2025
|
🎉 This PR is included in version 4.17.2-beta.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
github-actions bot
pushed a commit
that referenced
this pull request
Dec 8, 2025
# [5.0.0-beta.1](v4.17.1...v5.0.0-beta.1) (2025-12-08) ### Bug Fixes * response.write() to return a bool (resolves [#683](#683)) ([#702](#702)) ([d9be538](d9be538)) * support nested routes and custom domains ([#555](#555)) ([422bac1](422bac1)) ### Features * v5.0.0 - Node.js 24 support and removal of deprecated APIs ([a6263a3](a6263a3)) ### BREAKING CHANGES * Minimum Node.js version is now 24 (though earlier versions may work) * Handler no longer accepts callback parameter - async/Promise only * Removed resolutionMode option (CALLBACK/CONTEXT modes removed) * Removed binaryMimeTypes option (use binarySettings instead) * Removed deprecated createServer() and proxy() exports * Removed deprecated handler.handler() and handler.proxy() methods
|
🎉 This PR is included in version 5.0.0-beta.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Returning 'false'y tells the sender they need to wait for the 'drain' event which can cause middleware to hang (eg. SvelteKit adapter-node and trpc)
Original fix from @KATT in KATT@9ba260e
Issue #683:
Make response.write() return a bool (always 'true') to prevent middleware stalling waiting for a non-existent
drainevent.Description of changes:
...added
return true. :)Checklist
have been added andare passingBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.