Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sure a grade is always between 0 and 10 #326

Merged
merged 4 commits into from Dec 27, 2017

Conversation

Projects
None yet
2 participants
@libre-man
Copy link
Collaborator

libre-man commented Dec 27, 2017

Description

Make sure a grade is always between 0 and 10.

@libre-man libre-man force-pushed the fix-max-grade branch from 76f1466 to 0eab351 Dec 27, 2017

@olmokramer
Copy link
Collaborator

olmokramer left a comment

Sweet!

@codecov

This comment has been minimized.

Copy link

codecov bot commented Dec 27, 2017

Codecov Report

Merging #326 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #326      +/-   ##
==========================================
+ Coverage   98.65%   98.65%   +<.01%     
==========================================
  Files          26       26              
  Lines        2893     2904      +11     
==========================================
+ Hits         2854     2865      +11     
  Misses         39       39
Impacted Files Coverage Δ
psef/linters.py 100% <ø> (ø) ⬆️
psef/helpers.py 100% <100%> (ø) ⬆️
psef/models.py 98.82% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 50874e9...a743ce6. Read the comment docs.

@libre-man libre-man force-pushed the fix-max-grade branch from 10658d9 to 832e800 Dec 27, 2017

@libre-man libre-man merged commit 9c8821e into master Dec 27, 2017

5 checks passed

codecov/patch 100% of diff hit (target 98.65%)
Details
codecov/project 98.65% (+<.01%) compared to 50874e9
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.005%) to 98.657%
Details
pyup.io/safety-ci No dependencies with known security vulnerabilities.
Details

@wafflebot wafflebot bot removed the in progress label Dec 27, 2017

@libre-man libre-man deleted the fix-max-grade branch Dec 27, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.