Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix error when submitting for an LTI assignment without sourcedid #411

Merged
merged 6 commits into from Mar 30, 2018

Conversation

Projects
None yet
2 participants
@libre-man
Copy link
Collaborator

libre-man commented Mar 27, 2018

This closes #406.

@wafflebot wafflebot bot added the in progress label Mar 27, 2018

@libre-man libre-man force-pushed the fix-errors-during-invalid-lti-launch branch from e222cf2 to ab45bd3 Mar 27, 2018

@libre-man libre-man force-pushed the fix-errors-during-invalid-lti-launch branch from ab45bd3 to 16c53fa Mar 27, 2018

@codecov

This comment has been minimized.

Copy link

codecov bot commented Mar 27, 2018

Codecov Report

Merging #411 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #411      +/-   ##
==========================================
+ Coverage   99.04%   99.04%   +<.01%     
==========================================
  Files          29       29              
  Lines        3337     3343       +6     
==========================================
+ Hits         3305     3311       +6     
  Misses         32       32
Impacted Files Coverage Δ
psef/v1/assignments.py 100% <100%> (ø) ⬆️
psef/ignore.py 100% <100%> (ø) ⬆️
psef/models.py 99.25% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2476bb4...7b98ff2. Read the comment docs.

libre-man added some commits Mar 27, 2018

Merge branch 'fix-errors-during-invalid-lti-launch' of github.com:Cod…
…eGra-de/CodeGra.de into fix-errors-during-invalid-lti-launch

@olmokramer olmokramer merged commit 9f49459 into master Mar 30, 2018

5 checks passed

codecov/patch 100% of diff hit (target 99.04%)
Details
codecov/project 99.04% (+<.01%) compared to 2476bb4
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.002%) to 99.043%
Details
pyup.io/safety-ci No dependencies with known security vulnerabilities.
Details

@wafflebot wafflebot bot removed the in progress label Mar 30, 2018

@olmokramer olmokramer deleted the fix-errors-during-invalid-lti-launch branch Mar 30, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.