Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change homepage to login screen #480

Merged
merged 21 commits into from Sep 15, 2018

Conversation

Projects
None yet
3 participants
@libre-man
Copy link
Collaborator

commented Sep 6, 2018

No description provided.

@ghost ghost assigned libre-man Sep 6, 2018

@ghost ghost added the in progress label Sep 6, 2018

@codecov

This comment has been minimized.

Copy link

commented Sep 6, 2018

Codecov Report

Merging #480 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #480   +/-   ##
=======================================
  Coverage   99.08%   99.08%           
=======================================
  Files          29       29           
  Lines        3372     3372           
=======================================
  Hits         3341     3341           
  Misses         31       31

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8b97b70...06e2af4. Read the comment docs.

@olmokramer
Copy link
Collaborator

left a comment

There should be a max width on the inputs:

codegrade-login

When I log in it stays on the login page. I don't really know where to go instead, though, because we got rid of the assignments page.

This should also remove the images from static/ that aren't used anymore.

@DevinHillenius

This comment has been minimized.

Copy link
Collaborator

commented Sep 6, 2018

Looks like the old CodeGrade logo is still being used, however I also think the logo is maybe not needed.

Perhaps the login form could be smaller and could have a border around it?

libre-man added some commits Sep 6, 2018

@libre-man

This comment has been minimized.

Copy link
Collaborator Author

commented Sep 6, 2018

I do like the logo there, the max width and unused images issues are fixed. I think we should simply open the courses menu of the sidebar after logging in, but it is a difficult thing to determine. Especially as loading when logged in is quite confusing as it seems you are not logged in, and that should be fixed.

@olmokramer

This comment has been minimized.

Copy link
Collaborator

commented Sep 6, 2018

The inputs look nice now even on a big screen :)

But there's definitely something we should do about the login screen. As it is right now, even when you are logged in you still get to see the login page:

codegrade-login2

As you can see I'm logged in but I still get to see the login page... We'd talked about a landing page with useful information (links to assignments due shortly, courses with open assignments etc.) but until we've implemented such a page there should be a better alternative to the login page in my opinion, as it's very confusing right now.

It shouldn't be too much work to make such a page; most of the logic is already present in the sidebar, at least for a very barebones version. We can always improve upon it in the future. I think I have enough spare time tomorrow to make such a thing. Input is welcome of course, but otherwise I'll proceed on this branch tomorrow.

Also, I think the logo looks reaally nice there (i replaced it with the new logo locally), so I think we should keep it :)

@libre-man

This comment has been minimized.

Copy link
Collaborator Author

commented Sep 6, 2018

Ok I started to fix this. This is what somebody sees now on the homepage when logged in (the code needs to be cleaned though):

@olmokramer

This comment has been minimized.

Copy link
Collaborator

commented Sep 6, 2018

Wow that looks great already! Also very nice that you can access the assignment management from there! Maybe add a button for course management as well, next to the course name?

Did you generate the colours by hashing the course name? (Assuming because of the StackOverflow answer :p) They do not really fit the rest of the colour scheme. But that's fine for now, maybe in the future we can select a few colors that look somewhat nicer and use the hash to pick from those.

@libre-man

This comment has been minimized.

Copy link
Collaborator Author

commented Sep 7, 2018

The account used for the screenshot doesn't have course management permissions, but if the user has those permissions the gear already shows up.

The colors are picked from a list (using the hashing for consistent colors) that was created using http://colormind.io/ so the colors should match... But I'm open for other colors too.

@DevinHillenius

This comment has been minimized.

Copy link
Collaborator

commented Sep 7, 2018

Wow! Great job guys. I do agree the small clean logo looks great on the login page. Could I suggest a small white-ish border around the login form?

The colours of the courses look fine for now, but as Olmo suggested we could think of alternative pre-set colours to better match our own scheme in the future.

@olmokramer

This comment has been minimized.

Copy link
Collaborator

commented Sep 9, 2018

@libre-man commented on "2018-09-07T10:01:35Z - Replied by Github Reply Comments":

The account used for the screenshot doesn't have course management permissions, but if the user has those permissions the gear already shows up.

Ah that didn't cross my mind. Great!

The colors are picked from a list (using the hashing for consistent colors) that was created using http://colormind.io/ so the colors should match...

Well, that's just their opinion of "matching colors"... Doesn't change the fact that I don't like the way they look with the CodeGrade blue :)

@olmokramer

This comment has been minimized.

Copy link
Collaborator

commented Sep 9, 2018

@DevinHillenius commented on "2018-09-07T15:38:51Z - Replied by Github Reply Comments":

Wow! Great job guys.

This is all @libre-man ;-)

Could I suggest a small white-ish border around the login form?

I don't think I would like that, I like the clean look as it is. But if you guys do prefer it I'm also fine with it.

@libre-man

This comment has been minimized.

Copy link
Collaborator Author

commented Sep 9, 2018

I'm also against a border, I don't think it fits with the entire design. If we can find better colors, I think it is a good idea, however I think they are not that bad (not really good though).

@ghost ghost assigned olmokramer Sep 12, 2018

olmokramer added some commits Sep 12, 2018

@olmokramer
Copy link
Collaborator

left a comment

Nice work!

libre-man added some commits Sep 15, 2018

libre-man and others added some commits Sep 15, 2018

@olmokramer olmokramer merged commit d694ba7 into master Sep 15, 2018

5 checks passed

codecov/patch Coverage not affected when comparing 366e695...c721f83
Details
codecov/project 99.08% remains the same compared to 366e695
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage remained the same at 99.081%
Details
pyup.io/safety-ci No dependencies with known security vulnerabilities.
Details

@ghost ghost removed the in progress label Sep 15, 2018

@olmokramer olmokramer deleted the fix-frontpage branch Sep 23, 2018

olmokramer added a commit that referenced this pull request Oct 30, 2018

Merge pull request #653 from CodeGra-de/master
## Description
Release the stable release 'HereBeMonsters' (aka the glorious and infamous version `H`). This release adds:

### Major changes
- Add Plagiarism checkers (#486) (#513) (#536) (#555) (#508) (#556) (#645) (#576)
  It is now possible to check for plagiarism in CodeGrade. This enables privacy aware plagiarism checking. It is possible to use check against old CodeGrade assignment and upload base code and old submissions that are not in CodeGrade. For more information see our documentation.

- Make it possible give grades higher than ten (#500)
  Teachers can now indicate that students can receive a grader higher than 10 for an assignment, making it possible to create assignments with bonus points in CodeGrade. When using within LTI this requires a new LTI parameter.
  
  You should add the following to the `<blti:custom>` section of your canvas LTI config for CodeGrade:

  ```xml
  <lticm:property name="custom_canvas_points_possible">
    $Canvas.assignment.pointsPossible
  </lticm:property>
  ```
  

### Minor changes
- Change homepage to login screen (#480) (#496) (#501) (#557) (#616)
  The homepage has been improved to show all your courses and assignments at a glance when logged in.
- Allow .tar.xz archives to be uploaded (#492)
  This further improves the flexibility CodeGrade gives students when handing in submissions.
- Fix infinite loop overview mode (#477)
  In some combinations of permissions loading the overview mode resulted in an infinite loader.
- Add general feedback tab to overview mode (#523)
  This further decreases the chance that students will miss any of their feedback.
- Fix broken matchFiles function (#528) (#550)
  This fixes a bug that files changed inside a directory would not show up in the overview mode.
- Improve speed of diffing by using another library (#529)
  Viewer the diff between two large files is a lot faster!
- Remove the option to automatically generate keys (#554)
  It is no longer possible to generate the `secret_key` or `lti_secret_key` configuration options. Please update your config accordingly.
- Rewrite snippets manager (#551)
  This rewrite should make creating, using, deleting and updating snippets faster and more reliable.
- Drastically improve the experience of CodeGrade on mobile (#558)
  It is now way easier to use CodeGrade on mobile.
- Filter users in the user selector (#553)
  When selecting users (when uploading for others, or adding to courses) only show users will be shown that can be selected.
- Improve handling of LTI (#561) (#588)
  A complete rewrite of LTI backend handling. This should improve the stability of passbacks by a lot. This also guarantees that the submission date in Canvas and CodeGrade will match exactly.
  
  This also adds a new convenience route `/api/v1/lti/?lms=Canvas` to get lti config for the given LMS (Canvas only supported at the moment).
- Add items to the sidebar conditionally (#578) (#580) (#600)
  Depending on what page you are you will get extra items in the sidebar to help quick navigation. Currently plagiarism cases and submissions are added depending on the page.
- Start caching submissions (#643) (#636)
  Submissions are cached in the front-end so changing between the codeviewer and submissions list is now way quicker.
- Ensure all rubric rows have a maximum amount of >= 0 points (#579)
  It is no longer allowed to have rows in a rubric where the maximum possible score is < 0. If you needed this to create rubrics with bonus categories simply use the 'Max points' option in the rubric editor. All existing rubrics are not changed.


### Small changes and bugfixes
- Use new logos (#481) (#506)
  This updates our logo to the newest and greatest version!
- Various small bugs in the sidebar
- Add a minimum duration on the permission manager loaders (#521)
  This makes it clearer that permissions are actually updated.
- Throw an API error when a rubric row contains an empty header (#535)
  This is a backwards incompatible API change, however it doesn't change anything for the frontend.
- Fix horizontal overflow on codeviewer (#518)
  The codeviewer would sometimes overflow creating a vertical scrollbar when displaying files containing a large amount of consecutive tabs.
- Check if an assignment is loaded before getting its course (#549)
  In some rare cases LTI launches would fail be cause assignments were not loaded correctly.
- Add structured logging setup (#546)
  This makes it easier to follow requests and debug issues.
- Fix general feedback line wrapping (#570)
  Giving long lines as general feedback should be displayed correctly to the user now.
- Add manage assignment button to submission list (#574)
  It is now possible to easily navigate to the manage assignment page from the submissions list.
- Start using enum to store permissions in the backend (#571)
  Most routes will be faster by this design change.
- Improve filetree design (#599) (#611)  (#587)
  It is now easier to spot additions, changes and deletion directly in the filetree.
- Add ``<noscript>`` tag (#613)
  An error message will be displayed when javascript is disabled.
- Improve speed of filetree operations (#623)
  Loading large filetrees is now way quicker by using smarter data-structures.
- Add health route (#593)
  It is now possible to more easily monitor the health of your CodeGrade instance.
- Fix fontSize & contextAmount on submission page (#633)
  Sometimes the fields would show up empty, this shouldn't happen anymore!
- Replace submitted symlinks with actual files (#627)
  When a student uploads an archive with symlinks the student is warned and all symlinks are replaced by files explaining that the original files were symlinks but that those are not supported by CodeGrade.
- Fix grade history popover boundary (#625)
  The grade history would sometimes show up outside the screen, but no more!
- Make it impossible to submit empty archives (#622)
  A error is shown when a student tries to submit an archive without files.
- Show toast when local-storage doesn't work (#607)
  When a user has no local-storage available a warning is shown so the user knows that their experience might be sub-optimal.
- Show author of general feedback and line comments (#564) (#605)
  The author of all general feedback and line comments is displayed to the user. Only users with the `can_see_assignee` permission will see authors.
- Justify description popover text (#596)
  The text in descriptions is now justified and their popups will only show when the 'i' is clicked.
- Only submit rubric items or normal grade (#589)
  In some rare cases overriding rubrics would result in a race condition, resulting in wrong case.
- Redesign the download popover on the submission page (#595)
  This new design looks way better, but you tell us!
- Only show overview mode when you have permission to see feedback (#563)
  When you don't have permission to see feedback the overview mode will never be shown.
- Various other performance improvements (#566)
  We always strive for the best performance possible, and again in this release we increased the performance of CodeGrade! 🎉
- Make sure codeviewer is full width on medium pages (#591)
  This makes it easier to review and display code on smaller screens.
- Use custom font in toasted actions (#614)
  It is now always possible to close toasts, even when your font cannot display '✖'
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.