Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Various front-end UI fixes #763

Merged
merged 8 commits into from Feb 7, 2019

Conversation

Projects
None yet
2 participants
@libre-man
Copy link
Collaborator

libre-man commented Feb 6, 2019

Description

The fixes are:

  • Make sure the user component used correctly in the plagiarism viewer.
  • Fix sorting for the submission list
  • Fix the page title for the submission page
  • Fix overflowing sidebar

libre-man added some commits Feb 6, 2019

Fix plagiarism viewer
Make sure the user component is configured correctly and the correct props are used.

@wafflebot wafflebot bot added the in progress label Feb 6, 2019

libre-man added some commits Feb 7, 2019

@libre-man libre-man changed the title Fix plagiarism viewer Various front-end UI fixes Feb 7, 2019

@codecov

This comment has been minimized.

Copy link

codecov bot commented Feb 7, 2019

Codecov Report

Merging #763 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #763   +/-   ##
=======================================
  Coverage   99.37%   99.37%           
=======================================
  Files          57       57           
  Lines        5426     5426           
=======================================
  Hits         5392     5392           
  Misses         34       34

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0c48c7a...a963f6b. Read the comment docs.

@codecov

This comment has been minimized.

Copy link

codecov bot commented Feb 7, 2019

Codecov Report

Merging #763 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #763   +/-   ##
=======================================
  Coverage   99.37%   99.37%           
=======================================
  Files          57       57           
  Lines        5426     5426           
=======================================
  Hits         5392     5392           
  Misses         34       34

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0c48c7a...d07bc80. Read the comment docs.

libre-man added some commits Feb 7, 2019

@olmokramer olmokramer merged commit d92c231 into master Feb 7, 2019

7 of 8 checks passed

codeclimate/diff-coverage 25% (50% threshold)
Details
codeclimate All good!
Details
codeclimate/total-coverage 25% (0.0% change)
Details
codecov/patch Coverage not affected when comparing 0c48c7a...d07bc80
Details
codecov/project 99.37% remains the same compared to 0c48c7a
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage remained the same at 99.373%
Details
pyup.io/safety-ci No dependencies with known security vulnerabilities.
Details

@wafflebot wafflebot bot removed the in progress label Feb 7, 2019

@olmokramer olmokramer deleted the bugfix/fix-plagiarism-viewer branch Feb 7, 2019

@olmokramer olmokramer referenced this pull request Feb 7, 2019

Merged

Release version Izanami #784

olmokramer added a commit that referenced this pull request Feb 7, 2019

Merge pull request #784 from CodeGra-de/master
Version 1.2.19 (Izanami)
------------------------

**Released**: Februari 07th, 2019

**Features & Updates**

- Group assignments (#715): With this release we have added group assignments.
  It is possible to create groups, share them between assignments, and submit
  as a group. Groups can be given a nice name, that is easily remembered by
  the TA.
- Add support for 7zip as archive format (#738)
- Make late submissions stand out (#739): Submissions that have
  been handed in after the deadline are highlighted in the submissions list.
- Make it possible to display IPython notebooks (#742): CodeGrade now renders
  handed in IPython notebooks in the web interface instead of showing a JSON
  blob. Additionally, markdown files are also rendered. Teachers can place
  comments in both types of files, as well as on image files now. This also
  adds a message when a file does not end in a newline character.

**Minor updates**

- Show message when uploaded file is empty (#766): When a file is empty,
  it wouldn't show up at all in the code viewer. This changes it to show
  a message, indicating that the file is empty.
- Make the user selector more clear (#752): The user selector now
  shows a magnifying glass, indicating that the user can type to search for
  users.
- Use flatpickr datetime picker instead of native (#737): Date/time inputs have
  been changed to use a date picker, so users of browsers besides Chromium can
  now also pleasantly select a date or time.
- Change icon for user in the sidebar (#747)


**Fixes**

- Hide plagiarism providers when there is only one (#745)
- Make sure it is possible to ignore single files (#767): When a student
  submitted a single file instead of an archive, the student would not be warned
  that the file was ignored by the assignment's CGignore file.
- Make sure confirmations work correctly when submitFunction is used (#748)
- Improve grade viewer (#764): It was not possible to simultaneously submit a
  change to a rubric and override the grade calculated by the rubric.
- Various front-end UI fixes (#763)
- Various browser specific UI fixes (#768)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.